From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932176AbeBAAt2 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 31 Jan 2018 19:49:28 -0500
Received: from mailout2.samsung.com ([203.254.224.25]:19331 "EHLO
        mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932161AbeBAAtW (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 31 Jan 2018 19:49:22 -0500
DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20180201004920epoutp023f6f2cccecaf273ba97be1bbbf40e56d~PDT4m_BmZ2956029560epoutp02p
X-AuditID: b6c32a38-ac3ff70000001054-ac-5a72640f3ff7
Date: Thu, 01 Feb 2018 09:49:18 +0900
From: Andi Shyti <andi.shyti@samsung.com>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Simon Shields <simon@lineageos.org>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org, Andi Shyti <andi@etezian.org>,
        jeesw@melfas.com
Subject: Re: [PATCH 7/8] Input: mms114 - add SPDX identifier
Message-id: <20180201004918.GE7575@gangnam.samsung>
MIME-version: 1.0
Content-type: text/plain; charset="us-ascii"
Content-disposition: inline
In-reply-to: <20180131073138.GA1499@gmail.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLKsWRmVeSWpSXmKPExsWy7bCmvi5/SlGUQeskHYvFP54zWRxe9ILR
        ov1RJ6vFzU/fWC0u75rDZjFx/T1Wiy1nbrM5sHtcX/KJ2WPnrLvsHi3rN7F5fJ9xhtHj8ya5
        ANaoVJuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoDOU
        FMoSc0qBQgGJxcVK+nY2RfmlJakKGfnFJbZK0YaGRnqGBuZ6RkZGeibGsVZGpkAlCakZ/5u/
        shXs56h4+yS+gXEtWxcjB4eEgInEtrVFXYxcHEICOxgldh38xQ7hfGeUWHHlKnMXIydY0dwV
        X5kgEhsYJe6tPwFV9YlRYu6xUywgVSwCqhLfP75iB7HZBDQlmm7/AFshImAosfm+A0g9s8Ax
        RokZq0+BTRUWsJE4d28mWC+vgLHE71l/WCFsQYkfk++BxZkFdCTOHlvHCGFLSzz6OwNsPqeA
        nsTSta/B6kUFlCUWvJrCDnHpATaJa9PNIV5zkdgzVx4iLCzx6vgWdoiwtMSlo7YQ4WZGiW23
        k0FOkxCYwCjxaS/IkyAJY4lnC7uYINbySbz72sMK0csr0dEmBFHiIbHh9GdWCNtR4uLvBmj4
        7GSS2DzvHcsERtlZSL6ZheSbWUi+WcDIvIpRLLWgODc9tdiwwESvODG3uDQvXS85P3cTIzip
        aVnsYNxzzucQowAHoxIP74tLhVFCrIllxZW5hxglOJiVRHg3ihRFCfGmJFZWpRblxxeV5qQW
        H2I0BcbIRGYp0eR8YMLNK4k3NLE0MDEzAiYoS0NDJXHegACXKCGB9MSS1OzU1ILUIpg+Jg5O
        qQZGp6Of+oJSm9hK13myb9FakyURnKAt+l0jvW5J5NIV/+R9/jZcc5i74mHn1/buyGevJr8+
        +pLZ53lur2StT5yMq/eHLyszjsbVW0g/DduqYTij/G5iTt0uq8fKvyOeX5wqwyzXPFf6QkzZ
        65AL6ucEpkrfrldJLGE8pPv2mtN6oYUzN929941ZiaU4I9FQi7moOBEAavnt3IADAAA=
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCLMWRmVeSWpSXmKPExsVy+t9jQV3+lKIog+7VLBaLfzxnsji86AWj
        RfujTlaLm5++sVpc3jWHzWLi+nusFlvO3GZzYPe4vuQTs8fOWXfZPVrWb2Lz+D7jDKPH501y
        AaxRXDYpqTmZZalF+nYJXBn/m7+yFeznqHj7JL6BcS1bFyMnh4SAicTcFV+Zuhi5OIQE1jFK
        NPWeZoNwPjFK7J3RzwJSxSKgKvH94yt2EJtNQFOi6fYPoCIODhEBQ4nN9x1A6pkFjjBKNF/d
        DVYjLGAjce7eTLBeXgFjid+z/rBCDN3JJPHp8UI2iISgxI/J98CKmAW0JNbvPM4EYUtLPPo7
        A2wQp4CexNK1r1lBbFEBZYkFr6awT2Dkn4WkfRaS9llI2hcwMq9ilEwtKM5Nzy02KjDMSy3X
        K07MLS7NS9dLzs/dxAgM622Htfp2MN5fEn+IUYCDUYmH98Wlwigh1sSy4srcQ4wSHMxKIrwb
        RYqihHhTEiurUovy44tKc1KLDzFKc7AoifPezjsWKSSQnliSmp2aWpBaBJNl4uCUamBMuFJ7
        /9AW9l3bKs9qhJ1bZRQ/K0j+xuflXAdv6Nj/7Fu2tlzw1pLqTt2CC0JFT67vkDc9oThrb3mZ
        Q8zkk/dDwo+/XHFkzck3Ruyrk6emmdTIeMXM2CLQ3f+y9crDTuYEn5qL3C9TLvBNfxJ8I1R7
        bUK4ob5kasBhj0mKW6f+u/VC2W5iV0i6EktxRqKhFnNRcSIAwffuJ2cCAAA=
X-CMS-MailID: 20180201004919epcas1p1f5a77389be04bee25b911d1b3aeb309c
X-Msg-Generator: CA
CMS-TYPE: 101P
DLP-Filter: Pass
X-CFilter-Loop: Reflected
X-CMS-RootMailID: 20180129113331epcas2p193a0a99f660793fbfcf2ec825fac0e2c
X-RootMTR: 20180129113331epcas2p193a0a99f660793fbfcf2ec825fac0e2c
References: <20180129113323.18961-1-andi.shyti@samsung.com>
        <CGME20180129113331epcas2p193a0a99f660793fbfcf2ec825fac0e2c@epcas2p1.samsung.com>
        <20180129113323.18961-8-andi.shyti@samsung.com>
        <20180129194659.df7nlhwx4demk6o6@dtor-ws>
        <20180131060726.GB7575@gangnam.samsung> <20180131073138.GA1499@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Marcus,

> > > > - * Copyright (C) 2012 Samsung Electronics Co.Ltd
> > > > - * Author: Joonyoung Shim <jy0922.shim@samsung.com>
> > > > - *
> > > > - * This program is free software; you can redistribute it and/or modify
> > > > - * it under the terms of the GNU General Public License version 2 as
> > > > - * published by the Free Software Foundation.
> > > > - */
> > > > +// SPDX-License-Identifier: GPL-2.0
> > > > +// Samsung S6SY761 Touchscreen device driver
> > 
> > I'm very sorry, but my distrcation will kill me one day.
> 
> More coffee or sleep - your choice ;-)

I see that beer is not working, indeed :)

> > Is it possible to revert this patch or do you want me to send a
> > fix?
> 
> When you are on it;
> 
> Change
> MODULE_LICENSE("GPL");
> 
> to 
> MODULE_LICENSE("GPL v2");
> To match the former license text and SPDX-identifier.
> 
> See include/linux/module.h:
>  *	"GPL"				[GNU Public License v2 or later]
>  *	"GPL v2"			[GNU Public License v2]

I haven't noticed that. I will fix it in a separate patch.

Thanks,
Andi