From: Arnd Bergmann <arnd@arndb.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: [PATCH] vxfs: fix building with LTO
Date: Fri, 2 Feb 2018 16:47:01 +0100 [thread overview]
Message-ID: <20180202154706.1624997-1-arnd@arndb.de> (raw)
When link-time optimizations are enabled, vxfs fails to build:
fs/freevxfs/vxfs_lookup.c: In function 'vxfs_readdir':
fs/freevxfs/vxfs_subr.c:50:1: error: inlining failed in call to always_inline 'vxfs_put_page': function not declared inline and code size would grow
vxfs_put_page(struct page *pp)
^
fs/freevxfs/vxfs_lookup.c:291:3: note: called from here
vxfs_put_page(pp);
^
fs/freevxfs/vxfs_inode.c: In function '__vxfs_iget':
fs/freevxfs/vxfs_subr.c:50:1: error: inlining failed in call to always_inline 'vxfs_put_page': function not declared inline and code size would grow
fs/freevxfs/vxfs_lookup.c: In function 'vxfs_lookup':
fs/freevxfs/vxfs_subr.c:50:1: error: inlining failed in call to always_inline 'vxfs_put_page': function not declared inline and code size would grow
This removes the 'inline' annotation that obviously doesn't do much
anyway.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/freevxfs/vxfs_subr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/freevxfs/vxfs_subr.c b/fs/freevxfs/vxfs_subr.c
index e806694d4145..8e213cce586f 100644
--- a/fs/freevxfs/vxfs_subr.c
+++ b/fs/freevxfs/vxfs_subr.c
@@ -46,7 +46,7 @@ const struct address_space_operations vxfs_aops = {
.bmap = vxfs_bmap,
};
-inline void
+void
vxfs_put_page(struct page *pp)
{
kunmap(pp);
--
2.9.0
next reply other threads:[~2018-02-02 15:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 15:47 Arnd Bergmann [this message]
2018-02-02 18:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202154706.1624997-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®