From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Chen-Yu Tsai <wens@csie.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Corentin Labbe <clabbe.montjoie@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH 1/3] net: stmmac: dwmac-sun8i: drop V3s compatible and add V3 one
Date: Fri, 2 Feb 2018 23:13:01 +0100 [thread overview]
Message-ID: <20180202221301.judzaafcu67h4c2v@flea.lan> (raw)
In-Reply-To: <20180202180456.60378-2-icenowy@aosc.io>
[-- Attachment #1: Type: text/plain, Size: 614 bytes --]
On Sat, Feb 03, 2018 at 02:04:54AM +0800, Icenowy Zheng wrote:
> The V3s is just a differently packaged version of the V3 chip, which has
> a MAC with the same capability with H3. The V3s just doesn't wire out
> the external MII/RMII/RGMII bus. (V3 wired out it).
>
> Drop the compatible string of V3s in the dwmac-sun8i driver, and add a
> V3 compatible string, which has all capabilities.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
This breaks the DT ABI, so NAK.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-02 22:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 18:04 [PATCH 0/3] Allwinner V3s EMAC support Icenowy Zheng
2018-02-02 18:04 ` [PATCH 1/3] net: stmmac: dwmac-sun8i: drop V3s compatible and add V3 one Icenowy Zheng
2018-02-02 22:13 ` Maxime Ripard [this message]
2018-02-03 7:23 ` Icenowy Zheng
2018-02-05 13:39 ` Maxime Ripard
2018-02-03 6:00 ` [linux-sunxi] " Julian Calaby
2018-02-03 7:21 ` Icenowy Zheng
2018-02-02 18:04 ` [PATCH 2/3] ARM: sun8i: v3s: add V3s EMAC device tree node Icenowy Zheng
2018-02-02 18:04 ` [PATCH 3/3] ARM: sun8i: v3s: enable Ethernet port on the Lichee Pi Zero Dock Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202221301.judzaafcu67h4c2v@flea.lan \
--to=maxime.ripard@bootlin.com \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®