From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171AbeBCLnX (ORCPT ); Sat, 3 Feb 2018 06:43:23 -0500 Received: from merlin.infradead.org ([205.233.59.134]:39212 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751617AbeBCLnR (ORCPT ); Sat, 3 Feb 2018 06:43:17 -0500 Date: Sat, 3 Feb 2018 12:42:40 +0100 From: Peter Zijlstra To: Alan Cox Cc: kbuild test robot , kbuild-all@01.org, Stafford Horne , Will Deacon , Paul McKenney , Jonas Bonn , Stefan Kristiansson , David Howells , Arnd Bergmann , linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: asm-generic: Disallow no-op mb() for SMP systems Message-ID: <20180203114240.GU2269@hirez.programming.kicks-ass.net> References: <20180131130034.GR2269@hirez.programming.kicks-ass.net> <201802030326.M4zaX4v1%fengguang.wu@intel.com> <20180202202549.GT2269@hirez.programming.kicks-ass.net> <20180202210820.48ed7f87@alans-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180202210820.48ed7f87@alans-desktop> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 02, 2018 at 09:08:20PM +0000, Alan Cox wrote: > On Fri, 2 Feb 2018 21:25:49 +0100 > Peter Zijlstra wrote: > > > On Sat, Feb 03, 2018 at 04:00:35AM +0800, kbuild test robot wrote: > > > Hi Peter, > > > > > > I love your patch! Yet something to improve: > > > > Seriously? Bots have feelings? > > > > > [auto build test ERROR on asm-generic/master] > > > [also build test ERROR on v4.15 next-20180202] > > > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > > > > > url: https://github.com/0day-ci/linux/commits/Peter-Zijlstra/asm-generic-Disallow-no-op-mb-for-SMP-systems/20180203-000108 > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git master > > > config: m32r-usrv_defconfig (attached as .config) > > > compiler: m32r-linux-gcc (GCC) 7.2.0 > > > > Awesome, another broken architecture.. and this one is Orphaned :-( > > No maintainer to bug.. > > Renesas claim to still support the processor family so perhaps they can > provide a maintainer if you instead submit a patch to remove it from the > tree ;-) There's an idea :-) > From the documentation however the processor only does explicit dual > issue instructions, and the SMP is cache coherent so I'm not convinced > there is a problem with it. Thanks for looking at that, got a link handy to said documentation? Does it really not have a store-buffer? Getting such details sorted was exactly the purpose of the patch, so in that regards its a success :-)