From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752337AbeBFCkY (ORCPT ); Mon, 5 Feb 2018 21:40:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:47432 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752533AbeBFCkO (ORCPT ); Mon, 5 Feb 2018 21:40:14 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3622C21734 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Mon, 5 Feb 2018 21:40:11 -0500 From: Steven Rostedt To: Masami Hiramatsu Cc: Al Viro , Dmitry Safonov <0x7f454c46@gmail.com>, open list Subject: Re: [RFC] apparent bogosity in unregister_ftrace_function_probe_func() Message-ID: <20180205214011.2d55866e@vmware.local.home> In-Reply-To: <20180206112614.80e2a9cbfc55954ab904c3e3@kernel.org> References: <20180127031706.GE13338@ZenIV.linux.org.uk> <20180127170748.GF13338@ZenIV.linux.org.uk> <20180129225942.f2aec926e2ea223c52c34169@kernel.org> <20180205175433.6cd369db@gandalf.local.home> <20180206112614.80e2a9cbfc55954ab904c3e3@kernel.org> X-Mailer: Claws Mail 3.15.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 6 Feb 2018 11:26:14 +0900 Masami Hiramatsu wrote: > No, that code looks good to me. :) > > BTW, did you also remove "search = buff;" line in > unregister_ftrace_function_probe_func() too? That's a separate bug, and should be a separate patch. Dmitry mentioned that he was preparing a patch to fix that. Dmitry did you have a patch and added selftests to check it? If not, I'll whip one up. Thanks, -- Steve