From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: rostedt@goodmis.org, mingo@redhat.com, oleg@redhat.com,
wangnan0@huawei.com, masami.hiramatsu.pt@hitachi.com,
keescook@chromium.org, namhyung@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] trace_uprobe: Simplify probes_seq_show()
Date: Tue, 6 Feb 2018 04:47:39 -0800 [thread overview]
Message-ID: <20180206124739.GA57073@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180206093430.7550-2-ravi.bangoria@linux.vnet.ibm.com>
> Simplify probes_seq_show() function. We are using %lx to display
> the offset and we don't prepend unnecessary 0s in the offset.
>
The prepending of 0s was introduced by
tracing/uprobes: Do not print '0x (null)' when offset is 0
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a2fb3382
Wan,
Was there a reason to prepend 0s?
next prev parent reply other threads:[~2018-02-06 12:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 9:34 [PATCH 1/2] trace_uprobe: Use %lx to display offset Ravi Bangoria
2018-02-06 9:34 ` [PATCH 2/2] trace_uprobe: Simplify probes_seq_show() Ravi Bangoria
2018-02-06 12:47 ` Srikar Dronamraju [this message]
2018-02-08 3:29 ` Kees Cook
2018-02-08 3:43 ` Ravi Bangoria
2018-03-06 8:12 ` Ravi Bangoria
2018-03-06 22:04 ` Kees Cook
2018-03-07 4:12 ` Ravi Bangoria
2018-03-07 22:17 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206124739.GA57073@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
--cc=ravi.bangoria@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome