mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jerry Hoemann <jerry.hoemann@hpe.com>
To: wim@linux-watchdog.org, linux@roeck-us.net
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
	rwright@hpe.com, maurice.a.saldivar@hpe.com,
	Jerry Hoemann <jerry.hoemann@hpe.com>
Subject: [PATCH 05/10] watchdog/hpwdt: Update Module info.
Date: Tue,  6 Feb 2018 15:58:50 -0700	[thread overview]
Message-ID: <20180206225855.30582-6-jerry.hoemann@hpe.com> (raw)
In-Reply-To: <20180206225855.30582-1-jerry.hoemann@hpe.com>

Update Module Author and permission on parameters so that the
parameters show up in sysfs.

Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
---
 drivers/watchdog/hpwdt.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index a275f14bbcb0..3fae3119369f 100644
--- a/drivers/watchdog/hpwdt.c
+++ b/drivers/watchdog/hpwdt.c
@@ -427,20 +427,20 @@ static struct pci_driver hpwdt_driver = {
 	.remove		= hpwdt_exit,
 };
 
-MODULE_AUTHOR("Tom Mingarelli");
-MODULE_DESCRIPTION("hp watchdog driver");
+MODULE_AUTHOR("Jerry Hoemann");
+MODULE_DESCRIPTION("hpe watchdog driver");
 MODULE_LICENSE("GPL");
 MODULE_VERSION(HPWDT_VERSION);
 
-module_param(soft_margin, int, 0);
+module_param(soft_margin, int, 0444);
 MODULE_PARM_DESC(soft_margin, "Watchdog timeout in seconds");
 
-module_param(nowayout, bool, 0);
+module_param(nowayout, bool, 0444);
 MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default="
 		__MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
 
 #ifdef CONFIG_HPWDT_NMI_DECODING	/* { */
-module_param(allow_kdump, int, 0);
+module_param(allow_kdump, int, 0444);
 MODULE_PARM_DESC(allow_kdump, "Start a kernel dump after NMI occurs");
 #endif					/* } */
 
-- 
2.13.6

  parent reply	other threads:[~2018-02-06 23:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 22:58 [PATCH 00/10] watchdog/hpwdt: Update driver to use watchdog core Jerry Hoemann
2018-02-06 22:58 ` [PATCH 01/10] watchdog/hpwdt: Remove legacy NMI sourcing Jerry Hoemann
2018-02-11 17:52   ` [01/10] " Guenter Roeck
2018-02-11 17:56   ` Guenter Roeck
2018-02-06 22:58 ` [PATCH 02/10] watchdog/hpwdt: remove include files no longer needed Jerry Hoemann
2018-02-06 22:58 ` [PATCH 03/10] watchdog/hpwdt: Update nmi_panic message Jerry Hoemann
2018-02-06 22:58 ` [PATCH 04/10] watchdog/hpwdt: white space changes Jerry Hoemann
2018-02-06 22:58 ` Jerry Hoemann [this message]
2018-02-06 22:58 ` [PATCH 06/10] watchdog/hpwdt: Modify to use watchdog core Jerry Hoemann
2018-02-06 22:58 ` [PATCH 07/10] watchdog/hpwdt: Select WATCHDOG_CORE Jerry Hoemann
2018-02-06 22:58 ` [PATCH 08/10] watchdog/hpwdt: Programable Pretimeout NMI Jerry Hoemann
2018-02-06 22:58 ` [PATCH 09/10] watchdog/hpwdt: condition early return of NMI handler on iLO5 Jerry Hoemann
2018-02-06 22:58 ` [PATCH 10/10] watchdog/hpwdt: remove allow_kdump module parameter Jerry Hoemann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180206225855.30582-6-jerry.hoemann@hpe.com \
    --to=jerry.hoemann@hpe.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=maurice.a.saldivar@hpe.com \
    --cc=rwright@hpe.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®