From: Dan Carpenter <dan.carpenter@oracle.com>
To: l4stpr0gr4m@gmail.com
Cc: devel@driverdev.osuosl.org, arnd@arndb.de,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
justin@jvreeland.com, hdegoede@redhat.com,
himanshujha199640@gmail.com, hadess@hadess.net, joe@perches.com,
colin.king@canonical.com, davem@davemloft.net,
Larry.Finger@lwfinger.net
Subject: Re: [PATCH] Update rf_type_definition
Date: Wed, 7 Feb 2018 14:09:26 +0300 [thread overview]
Message-ID: <20180207110926.dzokcw2dwlinh2io@mwanda> (raw)
In-Reply-To: <1517952214-3434-1-git-send-email-l4stpr0gr4m@gmail.com>
This is better. But the subject should say [PATCH v2] and we need a
driver prefix.
On Wed, Feb 07, 2018 at 06:23:34AM +0900, l4stpr0gr4m@gmail.com wrote:
> From: Kangmin Park <l4stpr0gr4m@gmail.com>
>
> enum RT_RF_TYPE_DEFINITION on rtl8723bs/include/rtw_rf.h
> is different from enum tag_HAL_RF_Type_Definition on
> rtl8723bs/include/HalVerDef.h
>
> So, update them to be the same reference from
> enum rf_type on rtlwifi/wifi.h which recent version.
>
> As a result, ODM_RF_TYPE_E needs to be updated as well
> Therefore, it is updated reference from enum odm_rf_type
> on rtlwifi/phydm/phydm_pre_define.h too.
> And update some additional code to check more
> chip versions that resulted from it.
>
> Also, fixed some space required errors and
> line over 80 characters warnings by checkpatch.pl.
Don't do this. It's considered unrelated white space change and it
makes the code hard to review.
To be honest, I don't know the code well enough to say if this patch is
a good idea generally... It seems risky and I wish someone would test
it or a maintainer would Ack it.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-02-07 11:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 21:23 l4stpr0gr4m
2018-02-07 11:09 ` Dan Carpenter [this message]
2018-02-07 11:26 ` Kangmin Park
2018-03-14 11:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207110926.dzokcw2dwlinh2io@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=arnd@arndb.de \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=himanshujha199640@gmail.com \
--cc=joe@perches.com \
--cc=justin@jvreeland.com \
--cc=l4stpr0gr4m@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®