From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3233056-1518112664-2-13935916704830819516 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: cc='utf-8', plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1518112663; b=H0vRjeAbsopIxIe7i0GrrFSKlbKeRCD4DV+vWg+OFTW2puK YyVTxQfbjGbJSGi0iWvHJdM/Iai4x9vUERLnrn3H0EiOHy9X7s+XTsEngxEgSHZI yH8tg9seMfGdHqzxc+RTWkgYdp2HvXQB5ejgC0Tvc0KDuS+UXICpsh2KR9oDLnae 8GZRs5mGr3Ku7+HRnUaKtVsuS5A8DGaCFF0qdSzFwfRnRIyfAs9mvYaBkUz6o460 GJtZa8xodLzkG2eMpyDwx/2HfH5NiFHQJO6JQw5FfQodp2nv9HukRntHPOmOoHQR 1L4qSwOOX7a4CAa5678uU/gTyHxfMZ4Sf4+EhNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:content-transfer-encoding :in-reply-to:sender:list-id; s=arctest; t=1518112663; bh=qOSADIG zzJYLkG/ZdxjEOHitfGoqW2LV6er/zAGWtV0=; b=dk5aaQLEuUp/CU1N39HswVy Sk+r1el5WdOpz8CxAimn6yPqbNqXLo6I1F+9xNdjTYgJQm9J8tWB3TheKsW3JjYc CU81p5PM9fYQRlk23ABjUlUR1pAYl+dsTp+vSqWERUrvAK9M4zLj8wD1djZWjvR4 o15bkLxVs2tgw5apRbgVXG8j9zZuz64sz3EfWKybhOjmY0MasRnQ3sLJtewmrvdL lo/5ZQY5dz4kPFN86AoRVUGKwlfMlG+cuiuTXkm7CCyEiIMhNgV3FC8AUCo+gISY UzZMphub1lGqpmlufO+6jPiT3skn5yFgZHVACnzwoDgcyY+1hVZu6ePlT/gRmsQ= = ARC-Authentication-Results: i=1; mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes Authentication-Results: mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752059AbeBHR5m (ORCPT ); Thu, 8 Feb 2018 12:57:42 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:33432 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751094AbeBHR5l (ORCPT ); Thu, 8 Feb 2018 12:57:41 -0500 Date: Thu, 8 Feb 2018 18:57:38 +0100 From: Greg KH To: Paolo Bonzini Cc: "Woodhouse, David" , Jim Mattson , Radim =?utf-8?B?S3LEjW3DocWZ?= , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, KarimAllah Ahmed , stable@vger.kernel.org Subject: Re: [STABLE 4.9.y PATCH 0/9] Backport of KVM Speculation Control support Message-ID: <20180208175737.GA22067@kroah.com> References: <1517938181-15317-1-git-send-email-dwmw@amazon.co.uk> <9ea4d52a-7ae6-a179-2f86-1e7b77255387@redhat.com> <1517951146.3677.34.camel@amazon.co.uk> <20180208024959.GA16399@kroah.com> <20180208171436.GA3521@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.3 (2018-01-21) Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Thu, Feb 08, 2018 at 06:42:03PM +0100, Paolo Bonzini wrote: > On 08/02/2018 18:14, Greg KH wrote: > > On Thu, Feb 08, 2018 at 03:49:59AM +0100, Greg KH wrote: > >> On Tue, Feb 06, 2018 at 09:05:46PM +0000, Woodhouse, David wrote: > >>> > >>> > >>> On Tue, 2018-02-06 at 19:01 +0100, Paolo Bonzini wrote: > >>>> On 06/02/2018 18:29, David Woodhouse wrote: > >>>>> I've put together a linux-4.9.y branch at  > >>>>> http://git.infradead.org/retpoline-stable.git/shortlog/refs/heads/linux-4.9.y > >>>>>   > >>>>> Most of it is fairly straightforward, apart from the IBPB on context  > >>>>> switch for which Tim has already posted a candidate. I wanted some more > >>>>> review on my backports of the KVM bits though, including some extra > >>>>> historical patches I pulled in. > >>>> > >>>> Looks good!  Thanks for the work, > >>>> > >>>> Paolo > >>> > >>> Thanks. In that case, Greg, the full set is lined up in > >>> http://git.infradead.org/retpoline-stable.git/shortlog/refs/heads/linux-4.9.y > >>> or git://git.infradead.org/retpoline-stable linux-4.9.y > >> > >> Many thanks for all of this work. I've now queued up all of these. > > > > There's a problem with the backport of 6342c50ad12e ("KVM: nVMX: > > vmx_complete_nested_posted_interrupt() can't fail") as there is still a > > check in the function that can fail: > > > > vapic_page = kmap(vmx->nested.virtual_apic_page); > > if (!vapic_page) { > > WARN_ON(1); > > return -ENOMEM; > > } > > > > Do we need something else before this patch in order to fix this? I > > guess kmap really can't fail, should I just drop the whole (!vapic_page) > > check? > > Yes, that would be commit 42cf014d38d8822cce63703a467e00f65d000952. > Should David or I respin? No need, I can sneak it into the middle of the series :) I'll do it later tonight and let you know if I have any problems, thanks for pointing out the needed commit. greg k-h