From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752230AbeBHOHp (ORCPT ); Thu, 8 Feb 2018 09:07:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:43982 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750876AbeBHOHo (ORCPT ); Thu, 8 Feb 2018 09:07:44 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F52C20671 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org Date: Thu, 8 Feb 2018 23:07:41 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Al Viro , Masami Hiramatsu , Dmitry Safonov <0x7f454c46@gmail.com>, Shuah Khan Subject: Re: [RFC][PATCH 5/6] selftests/ftrace: Add some missing glob checks Message-Id: <20180208230741.d108a8ab9126e130265870d6@kernel.org> In-Reply-To: <20180206224541.667281142@goodmis.org> References: <20180206224338.446477232@goodmis.org> <20180206224541.667281142@goodmis.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 06 Feb 2018 17:43:43 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Al Viro discovered a bug in the glob ftrace filtering code where "*a*b" is > treated the same as "a*b", and functions that would be selected by "*a*b" > but not "a*b" are not selected with "*a*b". > > Add tests for patterns "*a*b" and "a*b*" to the glob selftest. Yeah, this is what we should have... Acked-by: Masami Hiramatsu Thank you! > > Link: http://lkml.kernel.org/r/20180127170748.GF13338@ZenIV.linux.org.uk > > Cc: Shuah Khan > Signed-off-by: Steven Rostedt (VMware) > --- > tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc > index 589d52b211b7..27a54a17da65 100644 > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc > @@ -29,6 +29,12 @@ ftrace_filter_check '*schedule*' '^.*schedule.*$' > # filter by *, end match > ftrace_filter_check 'schedule*' '^schedule.*$' > > +# filter by *mid*end > +ftrace_filter_check '*aw*lock' '.*aw.*lock$' > + > +# filter by start*mid* > +ftrace_filter_check 'mutex*try*' '^mutex.*try.*' > + > # Advanced full-glob matching feature is recently supported. > # Skip the tests if we are sure the kernel does not support it. > if grep -q 'accepts: .* glob-matching-pattern' README ; then > -- > 2.15.1 > > -- Masami Hiramatsu