From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751317AbeBIMQR (ORCPT ); Fri, 9 Feb 2018 07:16:17 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:46344 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750918AbeBIMQQ (ORCPT ); Fri, 9 Feb 2018 07:16:16 -0500 From: Suzuki K Poulose To: dave.martin@arm.com Cc: mark.rutland@arm.com, will.deacon@arm.com, ard.biesheuvel@linaro.org, marc.zyngier@arm.com, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jnair@caviumnetworks.com, ckadabi@codeaurora.org, Suzuki K Poulose Subject: Re: [PATCH 1/2] arm64: capabilities: Allow flexibility in scope Date: Fri, 9 Feb 2018 12:16:01 +0000 Message-Id: <20180209121605.14091-1-suzuki.poulose@arm.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180208173229.GA5862@e103592.cambridge.arm.com> References: <20180208173229.GA5862@e103592.cambridge.arm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> I'm not sure we need extra comments or documentation; I just want >>> to check that I've understood the patch correctly. >> >> So, would you prefer this split to the original patch ? > > I think splitting out this patch (1/2) makes sense. > > > For the second part (2/2) of the split, I still find that hard to > review. The commit message suggests trivially obvious refactoring > only, but I think there are three things going on: > > 1) moving functions around (with the intention of merging them) > 2) merging functions together > 3) other miscellaneous bits of refactoring, and cleanups that become > "obvious" after steps (1) and (2). > > The refactoring is likely straightfoward, but the resulting diff is > not (at least, I struggle to read it). > > Could you split the second part along the lines if (1)..(3) above? > I think that would make for much easier review. (Sorry to be a pain!) > > Also, the second patch leaves at least one function that does nothing > except call a second function that has no other caller. It may do > no harm to remove and inline any such function. (Falls under (3), > I guess.) > Here it goes... Suzuki K Poulose (4): arm64: capabilities: Prepare for grouping features and errata work arounds arm64: capabilities: Split the processing of errata work arounds arm64: capabilities: Allow features based on local CPU scope arm64: capabilities: Group handling of features and errata workarounds arch/arm64/kernel/cpufeature.c | 91 ++++++++++++++++++++---------------------- 1 file changed, 43 insertions(+), 48 deletions(-) -- 2.14.3