From: Bjorn Helgaas <helgaas@kernel.org>
To: Arjun Vynipadath <arjun@chelsio.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, leedom@chelsio.com, santosh@chelsio.com,
ganeshgr@chelsio.com, nirranjan@chelsio.com, kumaras@chelsio.com,
swise@opengridcomputing.com, hare@suse.de
Subject: Re: [REGRESSION, bisect] pci: cxgb4 probe fails after commit 104daa71b3961434 ("PCI: Determine actual VPD size on first access")
Date: Mon, 12 Feb 2018 11:43:41 -0600 [thread overview]
Message-ID: <20180212174341.GC75542@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <1516710549-26660-1-git-send-email-arjun@chelsio.com>
On Tue, Jan 23, 2018 at 05:59:09PM +0530, Arjun Vynipadath wrote:
> Sending on behalf of "Casey Leedom <leedom@chelsio.com>"
>
> Way back on April 11, 2016 we reported a regression in Linux kernel 4.6-rc2
> brought on by kernel.org commit 104daa71b396. This commit calculates the
> size of a PCI Device's VPD area by parsing the VPD Structure at offset 0x000,
> and restricts accesses to the VPD to that computed size.
>
> Our devices have a second VPD structure which is located starting at offset
> 0x400 which is the "real" VPD[1]. The 104daa71b396 commit (plus a follow on
> commit 408641e93aa5) caused efforts to read past the end of that computed
> length of the VPD to return silently without error leaving stack junk in the
> VPD read buffers.
>
> We introduced kernel.org commit cb92148b to allow a driver to tell the
> kernel how large the VPD area really is, introducing a new API
> pci_set_vpd_size() for this purpose.
>
> Now we've discovered a new subtlety to the problem.
>
> We have a KVM Hypervisor running a 4.9.70 kernel. So it has all of the
> above commits. When we attach our Physical Function 4 to a Virtual Machine
> and attempt to run cxgb4 in that VM, we see the problem again. The issue is
> that all of the VM Guest OS's efforts to access the PCIe VPD Capability are
> trapped into the KVM 4.9.70 kernel and executed there, with the results
> routed back to the VM Guest OS. The cxgb4 driver in the VM Guest OS uses
> the new pci_set_vpd_size() to notify the OS of the true size of the VPD, but
> that information of course is never sent to the KVM 4.9.70 Hypervisor.
> (And, truth be told, if the Guest OS were older than 4.6, it wouldn't even
> know that it needed to do this.) The result is that again we get silent VPD
> read failures with random stack garbage in the VPD read buffers. (sigh)
Let me pull out one tiny piece of this problem: If the VPD read
returns failure, the caller should not look at the read buffer. But
we should *never* copy random stack garbage into the read buffer, no
matter what the VPD read returns.
I guess it's the 4.9.70 kernel that's putting garbage into the VPD
read buffer? Is this something that needs to be fixed in the current
upstream kernel?
next prev parent reply other threads:[~2018-02-12 17:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 12:29 Arjun Vynipadath
2018-01-23 12:43 ` Ganesh Goudar
2018-02-12 17:43 ` Bjorn Helgaas [this message]
2018-02-12 17:56 ` Alexander Duyck
-- strict thread matches above, loose matches on Subject: below --
2016-04-12 5:29 Hariprasad Shenai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212174341.GC75542@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=arjun@chelsio.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=ganeshgr@chelsio.com \
--cc=hare@suse.de \
--cc=kumaras@chelsio.com \
--cc=leedom@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=santosh@chelsio.com \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®