From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: typo: remove space in #ifdef
Date: Tue, 13 Feb 2018 10:05:44 +0100 [thread overview]
Message-ID: <20180213090544.GE25201@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1518512382-29426-1-git-send-email-vincent.guittot@linaro.org>
On Tue, Feb 13, 2018 at 09:59:42AM +0100, Vincent Guittot wrote:
> Remove a useless space in # ifdef and align it with others
>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
> kernel/sched/fair.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 1070803..cad1932 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -2823,7 +2823,7 @@ void reweight_task(struct task_struct *p, int prio)
> }
>
> #ifdef CONFIG_FAIR_GROUP_SCHED
> -# ifdef CONFIG_SMP
> +#ifdef CONFIG_SMP
Heh, so this is one where Ingo and me disagree ;-) He likes that
indented preprocessor nonsense, whereas I just find it really
bothersome.
I try and hide these in patches that touch the surrounding code.
next prev parent reply other threads:[~2018-02-13 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 8:59 Vincent Guittot
2018-02-13 9:05 ` Peter Zijlstra [this message]
2018-02-13 9:31 ` Ingo Molnar
2018-02-13 9:37 ` [tip:sched/core] sched/fair: Remove stray " tip-bot for Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213090544.GE25201@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome