From: Michal Hocko <mhocko@kernel.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "David Rientjes" <rientjes@google.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [patch] kvm: suppress KVM_SET_GSI_ROUTING allocation failure
Date: Tue, 13 Feb 2018 16:58:16 +0100 [thread overview]
Message-ID: <20180213155816.GW3443@dhcp22.suse.cz> (raw)
In-Reply-To: <1083260b-dfcd-6354-4e0c-b7b162661b15@redhat.com>
On Tue 13-02-18 16:49:20, Paolo Bonzini wrote:
> On 13/02/2018 16:44, Michal Hocko wrote:
> > On Tue 13-02-18 16:03:09, Paolo Bonzini wrote:
[...]
> >> There have been quite a few reports of this from syzkaller and generally
> >> we've fixed them. It does seem like a recipe for NULL-pointer
> >> dereferences when the size is user-controlled (as in this case).
> >
> > We do return NULL for that case regardless the above. The patch just
> > doesn't warn. Or do you think it is helpful to warn?
>
> It certainly helps bringing potential issues in the spotlight (through
> fuzzing, mostly).
Fair enough.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-02-13 15:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 21:35 David Rientjes
2018-02-13 14:40 ` Paolo Bonzini
2018-02-13 14:48 ` Michal Hocko
2018-02-13 15:03 ` Paolo Bonzini
2018-02-13 15:44 ` Michal Hocko
2018-02-13 15:49 ` Paolo Bonzini
2018-02-13 15:58 ` Michal Hocko [this message]
2018-02-13 15:14 ` Christian Borntraeger
2018-02-13 15:17 ` Paolo Bonzini
2018-02-14 1:03 ` David Rientjes
2018-02-14 8:30 ` Christian Borntraeger
2018-02-14 10:10 ` Paolo Bonzini
2018-02-14 11:14 ` Christian Borntraeger
2018-02-14 11:32 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213155816.GW3443@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rientjes@google.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®