From: Darren Hart <dvhart@infradead.org>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: "Daniel Díaz" <daniel.diaz@linaro.org>,
linux-kselftest@vger.kernel.org,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Shuah Khan" <shuah@kernel.org>,
"open list:FUTEX SUBSYSTEM" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests/futex: Fix line continuation in Makefile
Date: Tue, 13 Feb 2018 18:03:52 -0800 [thread overview]
Message-ID: <20180214020352.GB5786@fury> (raw)
In-Reply-To: <6d498007-de71-2071-646c-05eeb81b2b08@osg.samsung.com>
On Tue, Feb 13, 2018 at 06:45:54PM -0700, Shuah Khan wrote:
> On 02/13/2018 06:33 PM, Darren Hart wrote:
> > On Tue, Feb 13, 2018 at 02:26:46PM -0700, Shuah Khan wrote:
> >> On 02/07/2018 10:24 AM, Daniel Díaz wrote:
> >>> The Makefile lacks a couple of line continuation backslashes
> >>> in an `if' clause, which produces an error while make'ing:
> >>>
> >>> $ make
> >>> make[1]: Entering directory `/[...]/linux/tools/testing/selftests/futex'
> >>> /bin/sh: -c: line 5: syntax error: unexpected end of file
> >>> make[1]: *** [all] Error 1
> >>> make[1]: Leaving directory `/[...]/linux/tools/testing/selftests/futex'
> >>> make: *** [all] Error 2
> >>>
> >
> > What is the failure scenario here? Is this shell specific? What does /bin/sh
> > point to for you?
>
> My understanding is that this problem is seen with make versions prior to 4.x.
> This specific problem is seen with make version 3.81
>
> I will let Daniel Díaz share details on his environment.
OK, thanks Shuah. I think this would be important to capture in the commit
message.
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2018-02-14 2:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 17:24 Daniel Díaz
2018-02-13 21:26 ` Shuah Khan
2018-02-14 1:33 ` Darren Hart
2018-02-14 1:45 ` Shuah Khan
2018-02-14 2:03 ` Darren Hart [this message]
2018-02-14 14:49 ` Daniel Díaz Rodríguez
2018-02-14 15:02 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214020352.GB5786@fury \
--to=dvhart@infradead.org \
--cc=daniel.diaz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=shuahkh@osg.samsung.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®