mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	stable <stable@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: objtool warnings on 4.14-stable/gcc-7.3.0
Date: Wed, 14 Feb 2018 16:45:25 -0600	[thread overview]
Message-ID: <20180214224525.esxiqt7yjjjpzyz4@treble> (raw)
In-Reply-To: <20180214222412.arg77l6vjpkje6pj@treble>

On Wed, Feb 14, 2018 at 04:24:12PM -0600, Josh Poimboeuf wrote:
> On Wed, Feb 14, 2018 at 04:11:15PM +0100, Arnd Bergmann wrote:
> > Hi Josh,
> > 
> > I recently did some randconfig testing with a plain 4.14-stable kernel
> > and gcc-7.3.0, and came across three distinct objtool warnings:
> > 
> > drivers/misc/lkdtm_bugs.o: warning: objtool:
> > lkdtm_CORRUPT_LIST_ADD()+0x15: return with modified stack frame

While this is probably an objtool bug, the code is very odd:

00000000000001a8 <lkdtm_CORRUPT_LIST_ADD>:
 1a8:   e8 00 00 00 00          callq  1ad <lkdtm_CORRUPT_LIST_ADD+0x5>
                        1a9: R_X86_64_PC32      __fentry__-0x4
 1ad:   55                      push   %rbp
 1ae:   48 89 e5                mov    %rsp,%rbp
 1b1:   48 83 e4 f0             and    $0xfffffffffffffff0,%rsp
 1b5:   48 83 ec 20             sub    $0x20,%rsp
 1b9:   48 89 ec                mov    %rbp,%rsp
 1bc:   5d                      pop    %rbp
 1bd:   c3                      retq

The function just allocates/aligns its stack space and then returns.  It
seems like GCC was too smart for its own good here, as the function
doesn't test what it's supposed to.  Can you share the config for this
one?

> > crypto/asymmetric_keys/x509_cert_parser.o: warning: objtool:
> > x509_note_pkey_algo()+0xa4: sibling call from callable instruction
> > with modified stack frame

>From a quick glance, this looks like yet another switch statement
detection issue.  I'll need to dig into it more (unless PeterZ, my shiny
new co-maintainer, wants to take a look!)

-- 
Josh

  reply	other threads:[~2018-02-14 22:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14 15:11 Arnd Bergmann
2018-02-14 22:24 ` Josh Poimboeuf
2018-02-14 22:45   ` Josh Poimboeuf [this message]
2018-02-15 14:04     ` Greg KH
2018-02-15 15:01     ` Arnd Bergmann
2018-02-15 15:25       ` Josh Poimboeuf
2018-02-15 15:59         ` Arnd Bergmann
2018-02-15 18:06           ` Kees Cook
2018-02-16  3:41             ` Kees Cook
2018-02-16 15:11               ` Arnd Bergmann
2018-02-28  2:20     ` Josh Poimboeuf
2018-02-28 11:26       ` Arnd Bergmann
2018-02-15 14:03   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180214224525.esxiqt7yjjjpzyz4@treble \
    --to=jpoimboe@redhat.com \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®