mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jerome Brunet <jbrunet@baylibre.com>
To: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] clk: use get_phase() if available
Date: Thu, 15 Feb 2018 11:28:22 +0100	[thread overview]
Message-ID: <20180215102822.7721-1-jbrunet@baylibre.com> (raw)

When the get_phase() callback is available, we should use it
instead of just relying the values cached, and assumed un-rounded,
by the framework

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---

Hi Mike, Stephen,

This changes applies on top of the phase fix I've sent [0]

[0]: https://lkml.kernel.org/r/20180215101958.22676-1-jbrunet@baylibre.com

 drivers/clk/clk.c | 25 ++++++++++++++++++++++---
 1 file changed, 22 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index b33d362239e7..bcd6ec980903 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -2297,6 +2297,21 @@ int clk_set_parent(struct clk *clk, struct clk *parent)
 }
 EXPORT_SYMBOL_GPL(clk_set_parent);
 
+static int clk_core_get_phase_nolock(struct clk_core *core)
+{
+	int ret;
+
+	if (!core->ops->get_phase)
+		return core->phase;
+
+	/* Update the phase if the callback is available */
+	ret = core->ops->get_phase(core->hw);
+	if (ret >= 0)
+		core->phase = ret;
+
+	return ret;
+}
+
 static int clk_core_set_phase_nolock(struct clk_core *core, int degrees)
 {
 	int ret = -EINVAL;
@@ -2314,12 +2329,16 @@ static int clk_core_set_phase_nolock(struct clk_core *core, int degrees)
 	if (core->ops->set_phase)
 		ret = core->ops->set_phase(core->hw, degrees);
 
-	if (!ret)
+	if (!ret) {
 		core->phase = degrees;
 
+		/* Read back the phase in case it got rounded */
+		ret = clk_core_get_phase_nolock(core);
+	}
+
 	trace_clk_set_phase_complete(core, degrees);
 
-	return ret;
+	return ret > 0 ? 0 : ret;
 }
 
 /**
@@ -2375,7 +2394,7 @@ static int clk_core_get_phase(struct clk_core *core)
 	int ret;
 
 	clk_prepare_lock();
-	ret = core->phase;
+	ret = clk_core_get_phase_nolock(core);
 	clk_prepare_unlock();
 
 	return ret;
-- 
2.14.3

             reply	other threads:[~2018-02-15 10:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-15 10:28 Jerome Brunet [this message]
2018-02-15 15:22 ` Jerome Brunet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180215102822.7721-1-jbrunet@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®