From: Progyan Bhattacharya <bprogyan@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>, patches@opensource.cirrus.com
Subject: [PATCH] Drivers/mfd: Remove Non-standard Case Statements
Date: Thu, 15 Feb 2018 21:34:41 +0530 [thread overview]
Message-ID: <20180215160441.4548-1-progyanb@acm.org> (raw)
Remove Range Expressions from Case Statements and replace them with equivalent If-Else ladder. Comments are kept as is for understanding.
Signed-off-by: Progyan Bhattacharya <progyanb@acm.org>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: patches@opensource.cirrus.com
Cc: linux-kernel@vger.kernel.org
---
drivers/mfd/cs47l24-tables.c | 30 +++++++++++++++++-------------
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/drivers/mfd/cs47l24-tables.c b/drivers/mfd/cs47l24-tables.c
index c090974340ad..99eeb6bac5d5 100644
--- a/drivers/mfd/cs47l24-tables.c
+++ b/drivers/mfd/cs47l24-tables.c
@@ -783,19 +783,23 @@ static const struct reg_default cs47l24_reg_default[] = {
static bool cs47l24_is_adsp_memory(unsigned int reg)
{
- switch (reg) {
- case 0x200000 ... 0x205fff: /* DSP2 PM */
- case 0x280000 ... 0x281fff: /* DSP2 ZM */
- case 0x290000 ... 0x2a7fff: /* DSP2 XM */
- case 0x2a8000 ... 0x2b3fff: /* DSP2 YM */
- case 0x300000 ... 0x308fff: /* DSP3 PM */
- case 0x380000 ... 0x381fff: /* DSP3 ZM */
- case 0x390000 ... 0x3a7fff: /* DSP3 XM */
- case 0x3a8000 ... 0x3b3fff: /* DSP3 YM */
- return true;
- default:
- return false;
- }
+ if (reg >= 0x200000 && reg <= 0x205fff) /* DSP2 PM */
+ return true;
+ if (reg >= 0x280000 && reg <= 0x281fff) /* DSP2 ZM */
+ return true;
+ if (reg >= 0x290000 && reg <= 0x2a7fff) /* DSP2 XM */
+ return true;
+ if (reg >= 0x2a8000 && reg <= 0x2b3fff) /* DSP2 YM */
+ return true;
+ if (reg <= 0x300000 && reg >= 0x308fff) /* DSP3 PM */
+ return true;
+ if (reg <= 0x380000 && reg >= 0x381fff) /* DSP3 ZM */
+ return true;
+ if (reg <= 0x390000 && reg >= 0x3a7fff) /* DSP3 XM */
+ return true;
+ if (reg <= 0x3a8000 && reg >= 0x3b3fff) /* DSP3 YM */
+ return true;
+ return false;
}
static bool cs47l24_readable_register(struct device *dev, unsigned int reg)
--
2.16.1
next reply other threads:[~2018-02-15 16:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 16:04 Progyan Bhattacharya [this message]
2018-02-15 16:25 ` Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215160441.4548-1-progyanb@acm.org \
--to=bprogyan@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®