From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Dan Williams <dan.j.williams@intel.com>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
David Woodhouse <dwmw@amazon.co.uk>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH V2] posix-timers: Protect posix clock array access against speculation
Date: Thu, 15 Feb 2018 18:01:04 +0100 [thread overview]
Message-ID: <20180215170104.GC25181@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <alpine.DEB.2.21.1802151718320.1296@nanos.tec.linutronix.de>
On Thu, Feb 15, 2018 at 05:21:55PM +0100, Thomas Gleixner wrote:
> The clockid argument of clockid_to_kclock() comes straight from user space
> via various syscalls and is used as index into the posix_clocks array.
>
> Protect it against spectre v1 array out of bounds speculation. Remove the
> redundant check for !posix_clock[id] as this is another source for
> speculation and does not provide any advantage over the return
> posix_clock[id] path which returns NULL in that case anyway.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: stable@vger.kernel.org
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
It might also be useful to figure out why the automation didn't flag
this one, its about as trivial as it gets.
next prev parent reply other threads:[~2018-02-15 17:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 13:27 [PATCH] " Thomas Gleixner
2018-02-15 14:05 ` Rasmus Villemoes
2018-02-15 14:39 ` Dan Williams
2018-02-15 14:53 ` Thomas Gleixner
2018-02-15 16:21 ` [PATCH V2] " Thomas Gleixner
2018-02-15 17:01 ` Peter Zijlstra [this message]
2018-03-07 18:13 ` Dan Williams
2018-03-22 11:34 ` [tip:timers/urgent] " tip-bot for Thomas Gleixner
2018-02-15 19:52 ` [PATCH] linux/nospec.h: allow index argument to have const-qualified type Rasmus Villemoes
2018-02-15 20:59 ` Linus Torvalds
2018-02-15 21:56 ` Dan Williams
2018-02-15 22:03 ` Linus Torvalds
2018-02-15 22:08 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215170104.GC25181@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dan.j.williams@intel.com \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rasmus.villemoes@prevas.dk \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®