From: Mark Brown <broonie@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc: Sebastian Reichel <sre@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec
Date: Fri, 16 Feb 2018 11:39:01 +0000 [thread overview]
Message-ID: <20180216113901.GC5886@sirena.org.uk> (raw)
In-Reply-To: <20180214220741.28306-3-sebastian.reichel@collabora.co.uk>
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]
On Wed, Feb 14, 2018 at 11:07:39PM +0100, Sebastian Reichel wrote:
> +config SND_SOC_CPCAP
> + tristate "Motorola CPCAP codec"
> + depends on MFD_CPCAP
> + default MFD_CPCAP
> +
We don't have default lines like this for other MFDs...
> + SOC_ENUM("Hifi Left Phase Playback Switch",
> + cpcap_hifi_l_phase_inv_enum),
> + SOC_ENUM("Ext Left Phase Playback Switch",
> + cpcap_ext_l_phase_inv_enum),
If this is a Switch control it should be a simple on/off binary control.
If it's an enumeration it shouldn't have Switch at the end of the name
since that's a keyword interpreted by userspace. Either option seems
fine in this case, if it's a switch it should be "Foo Invert Switch" or
similar.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-02-16 11:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 22:07 [PATCHv4 0/4] Motorola Droid 4 Audio Support Sebastian Reichel
2018-02-14 22:07 ` [PATCHv4 1/4] dt-bindings: sound: add motorola,cpcap-audio-codec Sebastian Reichel
2018-02-16 11:30 ` Mark Brown
2018-02-16 13:25 ` Sebastian Reichel
2018-02-16 13:44 ` Mark Brown
2018-02-16 14:12 ` Sebastian Reichel
2018-02-16 15:16 ` Mark Brown
2018-02-16 15:57 ` Tony Lindgren
2018-02-19 13:05 ` Mark Brown
2018-02-22 19:54 ` Tony Lindgren
2018-02-23 12:47 ` Sebastian Reichel
2018-02-16 15:58 ` Sebastian Reichel
2018-02-19 13:25 ` Mark Brown
2018-02-14 22:07 ` [PATCHv4 2/4] ASoC: codec: cpcap: new codec Sebastian Reichel
2018-02-15 9:50 ` Philippe Ombredanne
2018-02-16 13:31 ` Sebastian Reichel
2018-02-16 11:39 ` Mark Brown [this message]
2018-02-16 13:51 ` Sebastian Reichel
2018-02-16 14:27 ` Mark Brown
2018-02-23 8:07 ` Pavel Machek
2018-02-23 12:44 ` Sebastian Reichel
2018-02-14 22:07 ` [PATCHv4 3/4] ARM: dts: motorola-cpcap-mapphone: add audio-codec Sebastian Reichel
2018-02-14 22:07 ` [PATCHv4 4/4] ARM: dts: omap4-droid4: add soundcard Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180216113901.GC5886@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
--cc=sre@kernel.org \
--cc=tiwai@suse.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome