From: Mark Brown <broonie@kernel.org>
To: Cosmin-Gabriel Samoila <cosmin.samoila@nxp.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
robh@kernel.org, mihai.serban@gmail.com, linux-imx@nxp.com,
shegjiu.wang@nxp.com, daniel.baluta@nxp.com,
linux-kernel@vger.kernel.org,
Junichi Wakasugi <wakasugi.jb@om.asahi-kasei.co.jp>,
Mihai Serban <mihai.serban@nxp.com>,
Shengjiu Wang <shengjiu.wang@nxp.com>
Subject: Re: [PATCH v3 1/2] ASoC: codecs: Add support for AK4458 DAC driver
Date: Fri, 16 Feb 2018 11:54:36 +0000 [thread overview]
Message-ID: <20180216115436.GF5886@sirena.org.uk> (raw)
In-Reply-To: <1518614467-20613-2-git-send-email-cosmin.samoila@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 415 bytes --]
On Wed, Feb 14, 2018 at 03:21:06PM +0200, Cosmin-Gabriel Samoila wrote:
> --- /dev/null
> +++ b/sound/soc/codecs/ak4458.c
> @@ -0,0 +1,659 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Audio driver for AK4458 DAC
> + *
Please don't mix C and C++ comments line this, just make the entire
block a C++ comment. Since this looks otherwise good I'll apply this,
please send a followup patch fixing the above.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-02-16 11:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 13:21 [PATCH v3 0/2] Add support for AK4458 DAC Cosmin-Gabriel Samoila
2018-02-14 13:21 ` [PATCH v3 1/2] ASoC: codecs: Add support for AK4458 DAC driver Cosmin-Gabriel Samoila
2018-02-14 16:21 ` Andy Shevchenko
2018-02-14 21:35 ` Philippe Ombredanne
2018-02-16 11:54 ` Mark Brown [this message]
2018-02-16 12:04 ` Applied "ASoC: ak4458: Add support for AK4458 DAC driver" to the asoc tree Mark Brown
2018-02-14 13:21 ` [PATCH v3 2/2] ASoC: ak4458: Add bindings for AK4458 DAC Cosmin-Gabriel Samoila
2018-02-16 12:04 ` Applied "ASoC: ak4458: Add bindings for AK4458 DAC" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180216115436.GF5886@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=cosmin.samoila@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.serban@gmail.com \
--cc=mihai.serban@nxp.com \
--cc=robh@kernel.org \
--cc=shegjiu.wang@nxp.com \
--cc=shengjiu.wang@nxp.com \
--cc=wakasugi.jb@om.asahi-kasei.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®