From: Mark Brown <broonie@kernel.org>
To: Daniel Baluta <daniel.baluta@nxp.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
andy.shevchenko@gmail.com, fabio.estevam@nxp.com,
robh@kernel.org, linux-kernel@vger.kernel.org,
wakasugi.jb@om.asahi-kasei.co.jp, shengjiu.wang@nxp.com,
mihai.serban@gmail.com, cosmin.samoila@nxp.com,
linux-imx@nxp.com, daniel.baluta@gmail.com,
Mihai Serban <mihai.serban@nxp.com>
Subject: Re: [PATCH v4 1/2] ASoC: codecs: Add support for AK5558 ADC driver
Date: Fri, 16 Feb 2018 12:14:45 +0000 [thread overview]
Message-ID: <20180216121445.GH5886@sirena.org.uk> (raw)
In-Reply-To: <1518532174-11350-2-git-send-email-daniel.baluta@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 319 bytes --]
On Tue, Feb 13, 2018 at 04:29:33PM +0200, Daniel Baluta wrote:
> +++ b/sound/soc/codecs/ak5558.c
> @@ -0,0 +1,417 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
Just make this a C++ commment, don't mix C and C++ - it looks neater.
Otherwise this looks good so I'll apply, please send a followup patch
for the above.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-02-16 12:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 14:29 [PATCH v4 0/2] Add support for AK5558 ADC Daniel Baluta
2018-02-13 14:29 ` [PATCH v4 1/2] ASoC: codecs: Add support for AK5558 ADC driver Daniel Baluta
2018-02-16 12:14 ` Mark Brown [this message]
2018-02-16 12:28 ` Daniel Baluta
2018-02-19 17:13 ` Mark Brown
2018-02-16 12:16 ` Applied "ASoC: ak5558: Add support for AK5558 ADC driver" to the asoc tree Mark Brown
2018-02-13 14:29 ` [PATCH v4 2/2] ASoC: ak5558: Add bindings for AK5558 ADC Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180216121445.GH5886@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andy.shevchenko@gmail.com \
--cc=cosmin.samoila@nxp.com \
--cc=daniel.baluta@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.serban@gmail.com \
--cc=mihai.serban@nxp.com \
--cc=robh@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=wakasugi.jb@om.asahi-kasei.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®