From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yash Omer <yashomer0007@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net
Subject: Re: [PATCH] Staging: nvec: fix line should not end with a open parenthesis.
Date: Fri, 16 Feb 2018 15:55:19 +0300 [thread overview]
Message-ID: <20180216125519.odsteynuaielxpet@mwanda> (raw)
In-Reply-To: <20180216113634.12848-1-yashomer0007@gmail.com>
On Fri, Feb 16, 2018 at 05:06:34PM +0530, Yash Omer wrote:
> This patch fix line should not end with open parenthesis found by checkpatch.plscript.
>
> Signed-off-by: Yash Omer <yashomer0007@gmail.com>
> ---
> drivers/staging/nvec/nvec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 52054a528723..39fb737543b5 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -383,8 +383,8 @@ static void nvec_request_master(struct work_struct *work)
> msg = list_first_entry(&nvec->tx_data, struct nvec_msg, node);
> spin_unlock_irqrestore(&nvec->tx_lock, flags);
> nvec_gpio_set_value(nvec, 0);
> - err = wait_for_completion_interruptible_timeout(
> - &nvec->ec_transfer, msecs_to_jiffies(5000));
> + err = wait_for_completion_interruptible_timeout
> + (&nvec->ec_transfer, msecs_to_jiffies(5000));
The original code is basically fine... It's OK to ignore checkpatch in
this situation.
regards,
dan carpenter
next prev parent reply other threads:[~2018-02-16 12:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 11:36 Yash Omer
2018-02-16 11:39 ` David Laight
2018-02-16 12:55 ` Dan Carpenter [this message]
2018-02-16 17:13 ` [RFC patch] checkpatch: test identifier lengths Joe Perches
2018-02-16 20:31 ` Andrew Morton
2018-02-16 20:44 ` Greg KH
2018-02-16 21:05 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180216125519.odsteynuaielxpet@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yashomer0007@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®