From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033827AbeBPOLW (ORCPT ); Fri, 16 Feb 2018 09:11:22 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:42974 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033729AbeBPOLU (ORCPT ); Fri, 16 Feb 2018 09:11:20 -0500 Date: Fri, 16 Feb 2018 06:11:10 -0800 From: Matthew Wilcox To: "Kirill A. Shutemov" Cc: Ingo Molnar , x86@kernel.org, Thomas Gleixner , "H. Peter Anvin" , Linus Torvalds , Andy Lutomirski , Borislav Petkov , Andi Kleen , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] x86/xen: Allow XEN_PV and XEN_PVH to be enabled with X86_5LEVEL Message-ID: <20180216141110.GA10501@bombadil.infradead.org> References: <20180216114948.68868-1-kirill.shutemov@linux.intel.com> <20180216114948.68868-2-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180216114948.68868-2-kirill.shutemov@linux.intel.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 16, 2018 at 02:49:46PM +0300, Kirill A. Shutemov wrote: > @@ -38,12 +38,12 @@ > * > */ > > +#define l4_index(x) (((x) >> 39) & 511) > #define pud_index(x) (((x) >> PUD_SHIFT) & (PTRS_PER_PUD-1)) Shouldn't that be +#define p4d_index(x) (((x) >> P4D_SHIFT) & (PTRS_PER_P4D-1))