From: Tejun Heo <tj@kernel.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-ide@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Viresh Kumar <vireshk@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/3] pata_arasan_cf: Move two variable assignments in arasan_cf_probe()
Date: Sun, 18 Feb 2018 05:18:32 -0800 [thread overview]
Message-ID: <20180218131832.GA695913@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <0f5492bc-d239-401e-6f77-a27897e4ede5@users.sourceforge.net>
On Fri, Feb 16, 2018 at 05:00:11PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 16 Feb 2018 16:42:26 +0100
>
> Move assignments for the local variables "irq_handler" and "pdata"
> so that their setting will only be performed after a call
> of the function "devm_kzalloc" succeeded by this function.
> Thus adjust a corresponding if statement.
I'm not gonna apply this. If there's something preventing the
compiler from optimizing it, the right thing to do is fixing that.
Thanks.
--
tejun
prev parent reply other threads:[~2018-02-18 13:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 15:56 [PATCH 0/3] PATA-Arasan CF: Adjustments for arasan_cf_probe() SF Markus Elfring
2018-02-16 15:57 ` [PATCH 1/3] pata_arasan_cf: Delete an error message for a failed memory allocation in arasan_cf_probe() SF Markus Elfring
2018-02-19 3:40 ` Viresh Kumar
2018-02-16 15:59 ` [PATCH 2/3] pata_arasan_cf: Delete an unnecessary variable initialisation " SF Markus Elfring
2018-02-18 13:17 ` Tejun Heo
2018-02-16 16:00 ` [PATCH 3/3] pata_arasan_cf: Move two variable assignments " SF Markus Elfring
2018-02-18 13:18 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180218131832.GA695913@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome