mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pawel Dembicki <paweldembicki@gmail.com>
Cc: stable@vger.kernel.org, Pawel Dembicki <paweldembicki@gmail.com>,
	Evgeniy Polyakov <zbr@ioremap.net>,
	"Andrew F. Davis" <afd@ti.com>,
	Sebastian Reichel <sre@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] w1: gpio: fix problem with platfom data in w1-gpio
Date: Sun, 18 Feb 2018 18:19:26 +0100	[thread overview]
Message-ID: <20180218171927.6414-1-paweldembicki@gmail.com> (raw)
In-Reply-To: <20180218170629.6045-1-paweldembicki@gmail.com>

In devices, where fdt is used, is impossible to apply platform data
without proper fdt node.

This patch allow to use platform data in devices with fdt.

Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>
Acked-by: Andrew F. Davis <afd@ti.com>
---
 drivers/w1/masters/w1-gpio.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters/w1-gpio.c
index a90728ceec5a..7b80762941af 100644
--- a/drivers/w1/masters/w1-gpio.c
+++ b/drivers/w1/masters/w1-gpio.c
@@ -112,17 +112,16 @@ static int w1_gpio_probe_dt(struct platform_device *pdev)
 static int w1_gpio_probe(struct platform_device *pdev)
 {
 	struct w1_bus_master *master;
-	struct w1_gpio_platform_data *pdata;
+	struct w1_gpio_platform_data *pdata = dev_get_platdata(&pdev->dev);
 	int err;
 
-	if (of_have_populated_dt()) {
+	if (of_have_populated_dt() && !pdata) {
 		err = w1_gpio_probe_dt(pdev);
 		if (err < 0)
 			return err;
+		pdata = dev_get_platdata(&pdev->dev);
 	}
 
-	pdata = dev_get_platdata(&pdev->dev);
-
 	if (!pdata) {
 		dev_err(&pdev->dev, "No configuration data\n");
 		return -ENXIO;
-- 
2.14.1

       reply	other threads:[~2018-02-18 17:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180218170629.6045-1-paweldembicki@gmail.com>
2018-02-18 17:19 ` Pawel Dembicki [this message]
2018-02-19 13:29   ` Andrew F. Davis
2018-03-14 13:59   ` Greg Kroah-Hartman
2018-03-17 10:39     ` Paweł Dembicki
2018-03-17 11:55       ` Greg Kroah-Hartman
2018-03-29  9:47         ` Paweł Dembicki
2018-03-29 10:01           ` Greg Kroah-Hartman
2018-04-04 16:44             ` Paweł Dembicki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180218171927.6414-1-paweldembicki@gmail.com \
    --to=paweldembicki@gmail.com \
    --cc=afd@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sre@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome