From: Viresh Kumar <viresh.kumar@linaro.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] cpufreq: powernow-k8: Delete an unnecessary return statement in two functions
Date: Mon, 19 Feb 2018 09:14:27 +0530 [thread overview]
Message-ID: <20180219034427.GK28462@vireshk-i7> (raw)
In-Reply-To: <f673f072-86f3-ed72-e715-bed883551be4@users.sourceforge.net>
On 15-02-18, 20:30, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 15 Feb 2018 20:14:32 +0100
>
> The script "checkpatch.pl" pointed information out like the following.
>
> WARNING: void function return statements are not generally useful
>
> Thus remove such a statement in the affected functions.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/cpufreq/powernow-k8.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c
> index 460bf22a8a2b..782a8c2a359d 100644
> --- a/drivers/cpufreq/powernow-k8.c
> +++ b/drivers/cpufreq/powernow-k8.c
> @@ -122,14 +122,12 @@ static int query_current_values_with_pending_wait(struct powernow_k8_data *data)
> static void count_off_irt(struct powernow_k8_data *data)
> {
> udelay((1 << data->irt) * 10);
> - return;
> }
>
> /* the voltage stabilization time */
> static void count_off_vst(struct powernow_k8_data *data)
> {
> udelay(data->vstable * VST_UNITS_20US);
> - return;
> }
>
> /* need to init the control msr to a safe value (for each cpu) */
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
prev parent reply other threads:[~2018-02-19 3:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 19:28 [PATCH 0/2] cpufreq/PowerNow-K8: Adjustments for two function implementations SF Markus Elfring
2018-02-15 19:29 ` [PATCH 1/2] cpufreq: powernow-k8: Delete an error message for a failed memory allocation in three functions SF Markus Elfring
2018-02-19 3:44 ` Viresh Kumar
2018-02-15 19:30 ` [PATCH 2/2] cpufreq: powernow-k8: Delete an unnecessary return statement in two functions SF Markus Elfring
2018-02-19 3:44 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219034427.GK28462@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®