From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3881655-1519032350-2-16712557392280574888 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, UNPARSEABLE_RELAY 0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.138', Host='smtp1.osuosl.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1519032349; b=bQV8YfplsYepcKkbGFnJhr2oofdQurTVYK8MVAfQMo9cKQj xNLNWYddysDkJdq8GW3mTxvlb6HT94sM1Qjq0JRwlpZ7yV1NC7qJqgL5g2Lu57Ug ozKVD9fEfC6BFZZ6fQRyijganw/0EJwz/3w5PmRmZqnDMepsquBEJ4rAwb8C6flv Ox39D5g5ivyZb4Pt4iMy+QABu2kIOxhagfCgA/v4BEsjvGone7a7chBepcUtVWm7 HNiZl/ALMTLdf0QUsRMwpnYHDCdnw4OupyQlp6Tjc0ndIPP9HCLhbLpNCrPu3x6t RMnIJZBdFxHcn2WL3eqFrxNNzL+s36FzIY79AsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :references:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=arctest; t=1519032349; bh=y UP5njrRg0Nkvb4Gq0GJK1WVxTR/APvSY/L8Dv73LDk=; b=k14o0CLLGLb+Ke7vP jS2Wxx8kRtQBzbVszQ0Q+ObYZOQsW4XWjHlKQIbuFjkjpeuX2ALOD+sWOPpUy0F3 vVcrUThz9GYm1K5KK4T9a4dIbKX6qSkJJHSDKqakoNBf3YPKLACAoXpXMKcx3I13 MB4M/r2WjlFlIPwsMwlguXw+B2aScNEW0+V7bGiCmWWlPezGxwNvc3AJKsTlbfsg eapCzU877aunwrsiiRLJMZvm9wvBIEUXijoBzK1mFU4WJUmOmn0Cuonyq4N1krmb iw//kY/x+U1av9TyfyxnubwzLE14PsSXXOw1mzMCGiN0FZtUgK8NSyghHoqa1TMP 0dBZQ== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=oracle.com header.i=@oracle.com header.b=hprTUPyG x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=corp-2017-10-26; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=oracle.com; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=oracle.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=oracle.com header.i=@oracle.com header.b=hprTUPyG x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=corp-2017-10-26; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=oracle.com; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=oracle.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org Date: Mon, 19 Feb 2018 12:25:29 +0300 From: Dan Carpenter To: Quytelda Kahja Subject: Re: [PATCH 1/4] Staging: ks7010: sdio: Fix multiple use of arguments in RX/TX queue macros. Message-ID: <20180219092529.e4u4uk7krqs5q35g@mwanda> References: <20180217022053.24692-1-quytelda@tamalin.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180217022053.24692-1-quytelda@tamalin.org> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8808 signatures=668674 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=460 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1802190119 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, wsa@the-dreams.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Fri, Feb 16, 2018 at 06:20:50PM -0800, Quytelda Kahja wrote: > Use GCC extensions to prevent macro arguments from accidentally being evaluated > multiple times when the macro is called. > Don't over engineer code. These bugs are never going to occur in real life because of how the macros are used. It should be pretty easy to make these into functions anyway... Which is a much simpler, better solution. regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel