From: Catalin Marinas <catalin.marinas@arm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: John Garry <john.garry@huawei.com>,
Bhupesh Sharma <bhsharma@redhat.com>,
bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
Date: Mon, 19 Feb 2018 12:13:14 +0000 [thread overview]
Message-ID: <20180219121313.lltye3g464zzt7z3@armageddon.cambridge.arm.com> (raw)
In-Reply-To: <20180219111907.GB30394@arm.com>
On Mon, Feb 19, 2018 at 11:19:07AM +0000, Will Deacon wrote:
> > >>On 19/02/2018 06:39, Bhupesh Sharma wrote:
> > >>>Since commit e1a50de37860b3a93a9d643b09638db5aff47650 (arm64: cputype:
> > >>>Silence Sparse warnings), compilation of arm64 architecture is broken
> > >>>with the following error messages:
> > >>>
> > >>> AR arch/arm64/kernel/built-in.o
> > >>> arch/arm64/kernel/head.S: Assembler messages:
> > >>> arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> > >>> arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> > >>> arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> > >>> arch/arm64/kernel/head.S:677: Error: junk at end of line, first
> > >>> unrecognized character is `L'
> > >>> arch/arm64/kernel/head.S:677: Error: unexpected characters following
> > >>> instruction at operand 2 -- `movz x1,:abs_g1_s:0xff00ffffffUL'
> > >>> arch/arm64/kernel/head.S:677: Error: unexpected characters following
> > >>> instruction at operand 2 -- `movk x1,:abs_g0_nc:0xff00ffffffUL'
> > >>>
> > >>>This patch fixes the same by using the UL() macro correctly for
> > >>>assigning the MPIDR_HWID_BITMASK macro value.
> > >>>
> > >>>Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
[...]
> Thanks for the clarification; Catalin -- can you pick this up for -rc3 please?
Done. Strange that it builds fine with newer toolchains.
--
Catalin
next prev parent reply other threads:[~2018-02-19 12:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 6:39 Bhupesh Sharma
2018-02-19 10:19 ` John Garry
2018-02-19 11:02 ` Will Deacon
2018-02-19 11:12 ` John Garry
2018-02-19 11:19 ` Will Deacon
2018-02-19 12:13 ` Catalin Marinas [this message]
2018-02-19 11:26 ` Jan Glauber
2018-02-19 10:58 ` Arnd Bergmann
2018-02-22 4:32 ` Viresh Kumar
2018-02-19 12:09 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219121313.lltye3g464zzt7z3@armageddon.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=bhsharma@redhat.com \
--cc=bhupesh.linux@gmail.com \
--cc=john.garry@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®