From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: X86 ML <x86@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@amacapital.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] x86/dumpstack: Improve opcodes dumping in the Code: section
Date: Mon, 19 Feb 2018 16:02:19 -0600 [thread overview]
Message-ID: <20180219220219.lrnt2y6pcb7qyx4q@treble> (raw)
In-Reply-To: <20180219202826.19797-4-bp@alien8.de>
On Mon, Feb 19, 2018 at 09:28:24PM +0100, Borislav Petkov wrote:
> bool in_task_stack(unsigned long *stack, struct task_struct *task,
> @@ -358,8 +362,8 @@ void die(const char *str, struct pt_regs *regs, long err)
>
> static int __init code_bytes_setup(char *s)
> {
> - ssize_t ret;
> unsigned long val;
> + ssize_t ret;
>
> if (!s)
> return -EINVAL;
> @@ -372,35 +376,37 @@ static int __init code_bytes_setup(char *s)
> if (code_bytes > 8192)
> code_bytes = 8192;
>
> + if (code_bytes > OPCODE_BUFSIZE) {
> + u8 *new_buf = kzalloc(code_bytes, GFP_KERNEL);
> + if (!new_buf)
> + return -EINVAL;
S/EINVAL/ENOMEM/ ?
Otherwise the code looks good to me, and I like the new feature.
--
Josh
next prev parent reply other threads:[~2018-02-19 22:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 20:28 [PATCH 0/5] x86/dumpstack: Cleanups and user opcode bytes " Borislav Petkov
2018-02-19 20:28 ` [PATCH 1/5] x86/dumpstack: Unify show_regs() Borislav Petkov
2018-02-19 20:28 ` [PATCH 2/5] x86/dumpstack: Carve out Code: dumping into a function Borislav Petkov
2018-02-19 20:28 ` [PATCH 3/5] x86/dumpstack: Improve opcodes dumping in the Code: section Borislav Petkov
2018-02-19 22:02 ` Josh Poimboeuf [this message]
2018-02-19 20:28 ` [PATCH 4/5] x86/dumpstack: Add loglevel argument to show_opcodes() Borislav Petkov
2018-02-19 20:28 ` [RFC PATCH 5/5] x86/fault: Dump user opcode bytes on fatal faults Borislav Petkov
2018-02-20 19:14 ` [PATCH 0/5] x86/dumpstack: Cleanups and user opcode bytes Code: section Andy Lutomirski
2018-02-20 19:29 ` Josh Poimboeuf
2018-02-20 20:44 ` Borislav Petkov
2018-02-21 9:15 ` Ingo Molnar
2018-02-21 17:54 ` Borislav Petkov
2018-02-21 21:39 ` Linus Torvalds
2018-02-22 9:23 ` Peter Zijlstra
2018-02-22 18:42 ` Linus Torvalds
2018-02-23 15:22 ` Josh Poimboeuf
2018-02-23 20:12 ` Eric W. Biederman
2018-02-25 11:35 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219220219.lrnt2y6pcb7qyx4q@treble \
--to=jpoimboe@redhat.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®