From: Mark Brown <broonie@kernel.org>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: max9759: Add Amplifier Driver
Date: Tue, 20 Feb 2018 12:05:21 +0000 [thread overview]
Message-ID: <20180220120521.GC6378@sirena.org.uk> (raw)
In-Reply-To: <1519047958-22583-3-git-send-email-narmstrong@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 387 bytes --]
On Mon, Feb 19, 2018 at 02:45:58PM +0100, Neil Armstrong wrote:
> +++ b/sound/soc/codecs/max9759.c
> @@ -0,0 +1,207 @@
> +// SPDX-Licence-Identifier: GPL-2.0
> +/*
> + * MAX9759 Amplifier Driver
> + *
Please don't mix C and C++ style comments like this, make it all a C++
comment - it looks more intentional. Otherwise this looks good so I'll
apply, please send an incremental fixup.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2018-02-20 12:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 13:45 [PATCH 0/2] ASoC: Add support for max9759 " Neil Armstrong
2018-02-19 13:45 ` [PATCH 1/2] ASoC: Add DT bindings documentation for max9759 amplifier Neil Armstrong
2018-02-19 20:47 ` Rob Herring
2018-02-19 13:45 ` [PATCH 2/2] ASoC: max9759: Add Amplifier Driver Neil Armstrong
2018-02-20 12:05 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220120521.GC6378@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®