mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Moritz Fischer <mdf@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Moritz Fischer <mdf@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	Linux PM <linux-pm@vger.kernel.org>,
	Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH v2 2/2] power: reset: gpio-poweroff: Add support for timeout from DT
Date: Tue, 20 Feb 2018 08:41:22 -0800	[thread overview]
Message-ID: <20180220164122.GA32079@tyrael.ni.corp.natinst.com> (raw)
In-Reply-To: <CAHp75VfKXe-7pzPT=9N3r20YV5Sq1UyHPoYwoLL1L4mjt8cEUA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

On Tue, Feb 20, 2018 at 04:12:59PM +0200, Andy Shevchenko wrote:
> On Tue, Feb 20, 2018 at 12:59 AM, Moritz Fischer <mdf@kernel.org> wrote:
> > Add support for reading a timeout value from devicetree.
> > Fall back to previous default of 3s if nothing is specified.
> 
> 
> > +       of_property_read_u32(pdev->dev.of_node, "timeout_ms", &timeout);
> 
> Perhaps stop being OF-centric by using device_property_read_u32() instead?

Good catch, will do. Should probably change commit message accordingly,
too.

Thanks,

Moritz

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-02-20 16:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19 22:59 [PATCH v2 1/2] dt-bindings: power: reset: gpio-poweroff: Add 'timeout_ms' property Moritz Fischer
2018-02-19 22:59 ` [PATCH v2 2/2] power: reset: gpio-poweroff: Add support for timeout from DT Moritz Fischer
2018-02-20 14:12   ` Andy Shevchenko
2018-02-20 16:41     ` Moritz Fischer [this message]
2018-02-20 14:18 ` [PATCH v2 1/2] dt-bindings: power: reset: gpio-poweroff: Add 'timeout_ms' property Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180220164122.GA32079@tyrael.ni.corp.natinst.com \
    --to=mdf@kernel.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®