From: Tycho Andersen <tycho@tycho.ws>
To: Kees Cook <keescook@chromium.org>,
Andy Lutomirski <luto@amacapital.net>,
Oleg Nesterov <oleg@redhat.com>,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] ptrace, seccomp: add support for retrieving seccomp metadata
Date: Tue, 20 Feb 2018 19:49:25 -0700 [thread overview]
Message-ID: <20180221024925.2btdhf5oamn4tflz@cisco> (raw)
In-Reply-To: <20180220193051.GA22210@altlinux.org>
On Tue, Feb 20, 2018 at 10:30:52PM +0300, Dmitry V. Levin wrote:
> > +struct seccomp_metadata {
> > + unsigned long filter_off; /* Input: which filter */
> > + unsigned int flags; /* Output: filter's flags */
> > +};
>
> This "unsigned long" field is unacceptable unless you are willing
> to implement a compat layer for this arch-dependent type.
>
> Please use an arch-independent type instead.
> See e.g. struct ptrace_peeksiginfo_args or struct struct seccomp_data.
Whoops, sorry about that. I believe I've addressed it in
https://lkml.org/lkml/2018/2/20/755
Cheers,
Tycho
next prev parent reply other threads:[~2018-02-21 2:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 2:00 [PATCH v4 1/2] seccomp: hoist out filter resolving logic Tycho Andersen
2017-11-15 2:00 ` [PATCH v4 2/2] ptrace, seccomp: add support for retrieving seccomp metadata Tycho Andersen
2018-02-20 19:30 ` Dmitry V. Levin
2018-02-21 2:49 ` Tycho Andersen [this message]
2018-02-20 20:13 ` Eugene Syromiatnikov
2018-02-21 2:50 ` Tycho Andersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221024925.2btdhf5oamn4tflz@cisco \
--to=tycho@tycho.ws \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome