mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
	Ulf Magnusson <ulfalizer@gmail.com>,
	Eugeniu Rosca <roscaeugeniu@gmail.com>,
	"Luis R. Rodriguez" <mcgrof@kernel.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	linux-kernel@vger.kernel.org,
	Nicolas Pitre <nicolas.pitre@linaro.org>
Subject: Re: [PATCH] kconfig: Print reverse dependencies in groups
Date: Wed, 21 Feb 2018 12:10:40 +0100	[thread overview]
Message-ID: <20180221111038.clllad7wfhwd3dou@dell5510> (raw)
In-Reply-To: <1519191855-27943-1-git-send-email-yamada.masahiro@socionext.com>

Hi Masahiro,

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Petr Vorel <pvorel@suse.cz>
Just please fix typo leading to segfault and add ':'

<snip>
>  	get_symbol_props_str(r, sym, P_SELECT, _("  Selects: "));
>  	if (sym->rev_dep.expr) {
> -		str_append(r, _("  Selected by: \n"));
> -		expr_gstr_print_revdep(sym->rev_dep.expr, r);
> +		expr_gstr_print_revdep(sym->rev_dep.expr, r, yes, "  Selected by [y]\n");
> +		expr_gstr_print_revdep(sym->rev_dep.expr, r, mod, "  Selected by [m]\n");
> +		expr_gstr_print_revdep(sym->rev_dep.expr, r, no, "  Selected by [n]\n");
Maybe add ':' to be consistent with the rest of titles?
+		expr_gstr_print_revdep(sym->rev_dep.expr, r, yes, "  Selected by [y]:\n");
+		expr_gstr_print_revdep(sym->rev_dep.expr, r, mod, "  Selected by [m]:\n");
+		expr_gstr_print_revdep(sym->rev_dep.expr, r, no, "  Selected by [n]:\n");

>  	}

>  	get_symbol_props_str(r, sym, P_IMPLY, _("  Implies: "));
>  	if (sym->implied.expr) {
> -		str_append(r, _("  Implied by: \n"));
> -		expr_gstr_print_revdep(sym->implied.expr, r);
> +		expr_gstr_print_revdep(sym->rev_dep.expr, r, yes, "  Implied by [y]\n");
> +		expr_gstr_print_revdep(sym->rev_dep.expr, r, mod, "  Implied by [m]\n");
> +		expr_gstr_print_revdep(sym->rev_dep.expr, r, no, "  Implied by [n]\n");
And the same here.
+ the most important thing - copy paste error, which obviously leads to segfault on
"Implied by":
Try search for PTP_1588_CLOCK (in x86_64 defconfig). gdb in coredump shows
#0  0x000000000041043e in expr_print_revdep (e=0x0, fn=0x410297 <expr_print_gstr_helper>, data=0x7fff0f2a8640, pr_type=yes, title=0x7fff0f2a85a0) at scripts/kconfig/expr.c:1328
1328        if (e->type == E_OR) {

So the correct is:
		expr_gstr_print_revdep(sym->implied.expr, r, yes, "  Implied by [y]:\n");
		expr_gstr_print_revdep(sym->implied.expr, r, mod, "  Implied by [m]:\n");
		expr_gstr_print_revdep(sym->implied.expr, r, no, "  Implied by [n]:\n");


Kind regards,
Petr

  reply	other threads:[~2018-02-21 11:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-21  5:44 Masahiro Yamada
2018-02-21 11:10 ` Petr Vorel [this message]
2018-02-21 11:17   ` Petr Vorel
2018-02-21 13:51     ` Ulf Magnusson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180221111038.clllad7wfhwd3dou@dell5510 \
    --to=petr.vorel@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=rdunlap@infradead.org \
    --cc=roscaeugeniu@gmail.com \
    --cc=sam@ravnborg.org \
    --cc=ulfalizer@gmail.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®