From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938615AbeBUQPU (ORCPT ); Wed, 21 Feb 2018 11:15:20 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:33050 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754833AbeBUQPS (ORCPT ); Wed, 21 Feb 2018 11:15:18 -0500 X-Google-Smtp-Source: AH8x2260rcWwO2a2J3yHRkFdXTE+vVM5hjEMjFxNz5U+GIxXWtjko1xnsOrwLWwlT0PfdPOh2bJmqQ== Date: Wed, 21 Feb 2018 13:15:12 -0300 From: Rodrigo Siqueira To: Daniel Baluta Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Daniel Baluta , linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH] iio:dummy: Fix coding style in simple_dummy and evgen Message-ID: <20180221161512.bxpqtjwg4sxjphki@smtp.gmail.com> References: <20180221140533.lll6vbwg3gyjrlvi@smtp.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/21, Daniel Baluta wrote: > On Wed, Feb 21, 2018 at 4:05 PM, Rodrigo Siqueira > wrote: > > This patch fixes the following checkpatch.pl warnings: > > > > drivers/iio/dummy/iio_simple_dummy.c:603: WARNING: Block comments should > > align the * on each line > > drivers/iio/dummy/iio_dummy_evgen.c:151: WARNING: Symbolic permissions > > 'S_IWUSR' are not preferred. Consider using octal permissions '0200'... > > drivers/iio/dummy/iio_simple_dummy.c:693: CHECK: Please use a blank line > > after function/struct/union/enum declarations > > You are trying to fix 3 things in one patch here. Please don't do that. > > One patch per change please. Even for a simple comment line fix? > thanks, > Daniel.