From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932411AbeBUSw6 (ORCPT ); Wed, 21 Feb 2018 13:52:58 -0500 Received: from mx2.suse.de ([195.135.220.15]:45935 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932244AbeBUSw4 (ORCPT ); Wed, 21 Feb 2018 13:52:56 -0500 Date: Wed, 21 Feb 2018 19:52:52 +0100 From: Michal Hocko To: Dan Rue Cc: Andrew Morton , linux-mm@kvack.org, Mike Kravetz , Naoya Horiguchi , LKML Subject: Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API Message-ID: <20180221185252.GJ2231@dhcp22.suse.cz> References: <20180103093213.26329-1-mhocko@kernel.org> <20180103093213.26329-6-mhocko@kernel.org> <20180221042457.uolmhlmv5je5dqx7@xps> <20180221095526.GB2231@dhcp22.suse.cz> <20180221100107.GC2231@dhcp22.suse.cz> <20180221161914.ltssyoumwpyiwca6@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180221161914.ltssyoumwpyiwca6@xps> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 21-02-18 10:19:14, Dan Rue wrote: > On Wed, Feb 21, 2018 at 11:01:07AM +0100, Michal Hocko wrote: > > On Wed 21-02-18 10:55:26, Michal Hocko wrote: > > > On Tue 20-02-18 22:24:57, Dan Rue wrote: > > [...] > > > > I bisected the failure to this commit. The problem is seen on multiple > > > > architectures (tested x86-64 and arm64). > > > > > > The patch shouldn't have introduced any functional changes IIRC. But let > > > me have a look > > > > Hmm, I guess I can see it. Does the following help? > > --- > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > index 7c204e3d132b..a963f2034dfc 100644 > > --- a/mm/hugetlb.c > > +++ b/mm/hugetlb.c > > @@ -1583,7 +1583,7 @@ static struct page *alloc_surplus_huge_page(struct hstate *h, gfp_t gfp_mask, > > page = NULL; > > } else { > > h->surplus_huge_pages++; > > - h->nr_huge_pages_node[page_to_nid(page)]++; > > + h->surplus_huge_pages_node[page_to_nid(page)]++; > > } > > > > out_unlock: > > That did the trick. Confirmed fixed on v4.15-3389-g0c397daea1d4 and > v4.16-rc2 with the above patch. Thanks a lot for re-testing! Can I assume your Tested-by? -- Michal Hocko SUSE Labs