From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daniel Baluta <daniel.baluta@nxp.com>
Cc: "daniel.baluta@gmail.com" <daniel.baluta@gmail.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"jic23@kernel.org" <jic23@kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"rodrigosiqueiramelo@gmail.com" <rodrigosiqueiramelo@gmail.com>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>
Subject: Re: [PATCH v2] iio:dummy: Replace S_IWUSR by 0200
Date: Thu, 22 Feb 2018 11:25:27 +0300 [thread overview]
Message-ID: <20180222082527.wbiztlla4aondbeu@mwanda> (raw)
In-Reply-To: <1519286013.13463.59.camel@nxp.com>
> > Also who cares? The commit message is perfectly clear.
>
> I do care about newcomers really learning on how to write a proper
> commit message.
>
> The commit messsage should really say why the patch is needed, no what the patch does.
>
It fixes a checkpatch warning. The warning was right there in the patch
description!
> After several trivial patches newcomers will get into more serious stuff and I wouldn't
> want to see a patch with commit message like this:
>
> iio: Change bit 1 of status register
>
You seem to be complaining about about an imaginary patch from the
future??? If you've really built a time machine then focus on killing
Hitler instead of complaining about trivial bullshit.
regards,
dan carpenter
prev parent reply other threads:[~2018-02-22 8:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 19:28 Rodrigo Siqueira
2018-02-21 20:01 ` Julia Lawall
2018-02-22 8:11 ` Phil Reid
2018-02-21 21:01 ` Daniel Baluta
2018-02-22 7:43 ` Dan Carpenter
2018-02-22 7:53 ` Daniel Baluta
2018-02-22 8:25 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222082527.wbiztlla4aondbeu@mwanda \
--to=dan.carpenter@oracle.com \
--cc=daniel.baluta@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rodrigosiqueiramelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®