From: Arnd Bergmann <arnd@arndb.de>
To: Thomas Gleixner <tglx@linutronix.de>,
Yang Shi <yang.shi@linux.alibaba.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Ingo Molnar <mingo@kernel.org>,
Waiman Long <longman@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] debugobjects: fix debug_objects_freed accounting
Date: Thu, 22 Feb 2018 12:45:41 +0100 [thread overview]
Message-ID: <20180222114558.1307380-1-arnd@arndb.de> (raw)
The removal of the batched object freeing has caused the debug_objects_freed
to become read-only, and the reading is inside an ifdef, so gcc warns that it
is completely unused without CONFIG_DEBUG_FS:
lib/debugobjects.c:71:14: error: 'debug_objects_freed' defined but not used [-Werror=unused-variable]
Assuming we are still interested in this number, this adds back code to
count every instance we are about to free while we still hold the spinlock.
Fixes: 636e1970fd7d ("debugobjects: Use global free list in free_object()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
lib/debugobjects.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/debugobjects.c b/lib/debugobjects.c
index faab2c4ea024..748288dba512 100644
--- a/lib/debugobjects.c
+++ b/lib/debugobjects.c
@@ -235,6 +235,9 @@ static void free_obj_work(struct work_struct *work)
hlist_move_list(&obj_to_free, &tofree);
obj_nr_tofree = 0;
}
+ hlist_for_each_entry(obj, &tofree, node)
+ debug_objects_freed++;
+
raw_spin_unlock_irqrestore(&pool_lock, flags);
hlist_for_each_entry_safe(obj, tmp, &tofree, node) {
--
2.9.0
next reply other threads:[~2018-02-22 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 11:45 Arnd Bergmann [this message]
2018-02-22 13:58 ` Waiman Long
2018-02-22 15:50 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222114558.1307380-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®