mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: <broonie@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>
Subject: [PATCH 2/5] regmap: Remove unnecessary printk for failed allocation
Date: Thu, 22 Feb 2018 12:59:11 +0000	[thread overview]
Message-ID: <20180222125914.17016-2-ckeepax@opensource.cirrus.com> (raw)
In-Reply-To: <20180222125914.17016-1-ckeepax@opensource.cirrus.com>

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
 drivers/base/regmap/regmap.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index 8a6de76f89bb..c84c4d5d2df7 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -2052,10 +2052,9 @@ int regmap_bulk_write(struct regmap *map, unsigned int reg, const void *val,
 			return -EINVAL;
 
 		wval = kmemdup(val, val_count * val_bytes, map->alloc_flags);
-		if (!wval) {
-			dev_err(map->dev, "Error in memory allocation\n");
+		if (!wval)
 			return -ENOMEM;
-		}
+
 		for (i = 0; i < val_count * val_bytes; i += val_bytes)
 			map->format.parse_inplace(wval + i);
 
-- 
2.11.0

  reply	other threads:[~2018-02-22 12:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22 12:59 [PATCH 1/5] regmap: Format data for raw write in regmap_bulk_write Charles Keepax
2018-02-22 12:59 ` Charles Keepax [this message]
2018-02-22 12:59 ` [PATCH 3/5] regmap: Move the handling for max_raw_write into regmap_raw_write Charles Keepax
2018-02-26 11:17   ` Applied "regmap: Move the handling for max_raw_write into regmap_raw_write" to the regmap tree Mark Brown
2018-02-22 12:59 ` [PATCH 4/5] regmap: Tidy up regmap_raw_write chunking code Charles Keepax
2018-02-26 11:17   ` Applied "regmap: Tidy up regmap_raw_write chunking code" to the regmap tree Mark Brown
2018-02-22 12:59 ` [PATCH 5/5] regmap: Merge redundant handling in regmap_bulk_write Charles Keepax
2018-02-26 11:17   ` Applied "regmap: Merge redundant handling in regmap_bulk_write" to the regmap tree Mark Brown
2018-02-26 11:18 ` Applied "regmap: Format data for raw write " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180222125914.17016-2-ckeepax@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®