From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751455AbeBWEWH (ORCPT ); Thu, 22 Feb 2018 23:22:07 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:46875 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372AbeBWEWG (ORCPT ); Thu, 22 Feb 2018 23:22:06 -0500 X-Google-Smtp-Source: AH8x224HPrIgGTPy+POrzsvFwbJed8jciAKu1FU37Xoy4rbatNc3Q+Jyc4K2M5VEZ/RAEITthC91XQ== Date: Fri, 23 Feb 2018 09:52:03 +0530 From: Viresh Kumar To: Sudeep Holla Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" Subject: Re: [PATCH] cpufreq: scpi: drop redundant arm_big_little config dependency Message-ID: <20180223042203.GC26947@vireshk-i7> References: <1519322423-27956-1-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1519322423-27956-1-git-send-email-sudeep.holla@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22-02-18, 18:00, Sudeep Holla wrote: Not sure if 'redundant' is the right term to be used here. I would rather say: "Fix incorrect config dependency" :) > Commit 343a8d17fa8d (cpufreq: scpi: remove arm_big_little dependency) > removed the SCPI cpufreq dependency on arm_big_little cpufreq driver. > However the Kconfig entry still depends on ARM_BIG_LITTLE_CPUFREQ > which is clearly wrong. > > This patch removes that unnecessary Kconfig dependency. > > Fixes: 343a8d17fa8d (cpufreq: scpi: remove arm_big_little dependency) > Reported-by: Quentin Perret > Cc: "Rafael J. Wysocki" > Cc: Viresh Kumar > Signed-off-by: Sudeep Holla > --- > drivers/cpufreq/Kconfig.arm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm > index 2e49673a9e21..9bbb5b39d18a 100644 > --- a/drivers/cpufreq/Kconfig.arm > +++ b/drivers/cpufreq/Kconfig.arm > @@ -44,10 +44,10 @@ config ARM_DT_BL_CPUFREQ > > config ARM_SCPI_CPUFREQ > tristate "SCPI based CPUfreq driver" > - depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI > + depends on ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI > help > - This adds the CPUfreq driver support for ARM big.LITTLE platforms > - using SCPI protocol for CPU power management. > + This adds the CPUfreq driver support for ARM platforms using SCPI > + protocol for CPU power management. > > This driver uses SCPI Message Protocol driver to interact with the > firmware providing the CPU DVFS functionality. Acked-by: Viresh Kumar -- viresh