From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Ulf Magnusson <ulfalizer@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Tomasz Figa <tfiga@chromium.org>,
Paul Burton <paul.burton@mips.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Hans-Christian Noren Egtvedt <egtvedt@samfundet.no>,
Linus Walleij <linus.walleij@linaro.org>,
Vineet Gupta <vgupta@synopsys.com>,
Mel Gorman <mgorman@techsingularity.net>,
Christoph Hellwig <hch@lst.de>,
Michal Nazarewicz <mina86@mina86.com>,
Rob Herring <robh@kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Paul Mackerras <paulus@ozlabs.org>,
Will Deacon <will.deacon@arm.com>,
Tony Lindgren <tony@atomide.com>,
Nicholas Piggin <npiggin@gmail.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default
Date: Fri, 23 Feb 2018 10:35:03 +0000 [thread overview]
Message-ID: <20180223103455.GA20461@e107981-ln.cambridge.arm.com> (raw)
In-Reply-To: <20180223002142.GG14632@bhelgaas-glaptop.roam.corp.google.com>
On Thu, Feb 22, 2018 at 06:21:42PM -0600, Bjorn Helgaas wrote:
> On Fri, Feb 23, 2018 at 12:42:28AM +0100, Ulf Magnusson wrote:
> > On Fri, Feb 23, 2018 at 12:00 AM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> > > On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote:
> > >> 'default N' should be 'default n', though they happen to have the same
> > >> effect here, due to undefined symbols (N in this case) evaluating to n
> > >> in a tristate sense.
> > >>
> > >> Remove the default instead of changing it. bool and tristate symbols
> > >> implicitly default to n.
> > >
> > > s/bool/Bool/
> >
> > Not a great excuse, but I was thinking syntactically -- 'bool' and
> > 'tristate' symbols... :)
> >
> > >
> > >> Discovered with the
> > >> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> > >> script.
> > >>
> > >> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> > >
> > > Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> > >
> > > Since only this patch was posted to linux-pci, I assume it will be merged
> > > via some other tree.
> >
> > I didn't have a particular tree in mind for this patchset. I imagined
> > people would pick up patches into the trees where they make the most
> > sense, and only created the patchset to keep track of the patches more
> > easily. Might have created some confusion in retrospect.
> >
> > I just did a --cc-cmd="scripts/get_maintainer.pl -i" for the
> > individual patches by the way.
>
> OK, then either Lorenzo or I will pick it up.
>
> It's in drivers/pci/host/, so ideally Lorenzo will take it since he
> looks after everything else in there.
Sure I will take it, thanks.
Lorenzo
next prev parent reply other threads:[~2018-02-23 10:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0180206191126.GB98765@bhelgaas-glaptop.roam.corp.google.com>
2018-02-06 22:11 ` Ulf Magnusson
2018-02-22 23:00 ` Bjorn Helgaas
2018-02-22 23:42 ` Ulf Magnusson
2018-02-23 0:21 ` Bjorn Helgaas
2018-02-23 10:35 ` Lorenzo Pieralisi [this message]
2018-02-23 11:52 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223103455.GA20461@e107981-ln.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=egtvedt@samfundet.no \
--cc=hch@lst.de \
--cc=helgaas@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@techsingularity.net \
--cc=mina86@mina86.com \
--cc=npiggin@gmail.com \
--cc=paul.burton@mips.com \
--cc=paulus@ozlabs.org \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=tfiga@chromium.org \
--cc=tony@atomide.com \
--cc=ulfalizer@gmail.com \
--cc=vgupta@synopsys.com \
--cc=will.deacon@arm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®