From: Yazen Ghannam <Yazen.Ghannam@amd.com>
To: linux-efi@vger.kernel.org
Cc: Yazen Ghannam <Yazen.Ghannam@amd.com>,
linux-kernel@vger.kernel.org, ard.biesheuvel@linaro.org,
bp@suse.de, x86@kernel.org
Subject: [PATCH 6/8] efi: Decode additional IA32/X64 Bus Check fields
Date: Fri, 23 Feb 2018 14:03:31 -0600 [thread overview]
Message-ID: <20180223200333.6410-7-Yazen.Ghannam@amd.com> (raw)
In-Reply-To: <20180223200333.6410-1-Yazen.Ghannam@amd.com>
From: Yazen Ghannam <yazen.ghannam@amd.com>
The "Participation Type", "Time Out", and "Address Space" fields are
unique to the IA32/X64 Bus Check structure. Print these fields.
Based on UEFI 2.7 Table 259. IA32/X64 Bus Check Structure
Cc: <stable@vger.kernel.org> # 4.16.x
Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
---
drivers/firmware/efi/cper-x86.c | 44 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/drivers/firmware/efi/cper-x86.c b/drivers/firmware/efi/cper-x86.c
index 75f664043076..df4cf6221d8e 100644
--- a/drivers/firmware/efi/cper-x86.c
+++ b/drivers/firmware/efi/cper-x86.c
@@ -42,6 +42,10 @@
#define CHECK_VALID_RESTARTABLE_IP BIT_ULL(6)
#define CHECK_VALID_OVERFLOW BIT_ULL(7)
+#define CHECK_VALID_BUS_PART_TYPE BIT_ULL(8)
+#define CHECK_VALID_BUS_TIME_OUT BIT_ULL(9)
+#define CHECK_VALID_BUS_ADDR_SPACE BIT_ULL(10)
+
#define CHECK_VALID_BITS(check) ((check & GENMASK_ULL(15, 0)))
#define CHECK_TRANS_TYPE(check) ((check & GENMASK_ULL(17, 16)) >> 16)
#define CHECK_OPERATION(check) ((check & GENMASK_ULL(21, 18)) >> 18)
@@ -52,6 +56,10 @@
#define CHECK_RESTARTABLE_IP BIT_ULL(28)
#define CHECK_OVERFLOW BIT_ULL(29)
+#define CHECK_BUS_PART_TYPE(check) ((check & GENMASK_ULL(31, 30)) >> 30)
+#define CHECK_BUS_TIME_OUT BIT_ULL(32)
+#define CHECK_BUS_ADDR_SPACE(check) ((check & GENMASK_ULL(34, 33)) >> 33)
+
enum err_types {
ERR_TYPE_CACHE = 0,
ERR_TYPE_TLB,
@@ -92,6 +100,20 @@ static const char * const ia_check_op_strs[] = {
"snoop",
};
+static const char * const ia_check_bus_part_type_strs[] = {
+ "Local Processor originated request",
+ "Local Processor responded to request",
+ "Local Processor observed",
+ "Generic",
+};
+
+static const char * const ia_check_bus_addr_space_strs[] = {
+ "Memory Access",
+ "Reserved",
+ "I/O",
+ "Other Transaction",
+};
+
static inline void print_bool(char *str, const char *pfx, u64 check, u64 bit)
{
printk("%s%s: %s\n", pfx, str, (check & bit) ? "true" : "false");
@@ -144,6 +166,28 @@ static void print_err_info(const char *pfx, enum err_types err_type, u64 check)
if (validation_bits & CHECK_VALID_OVERFLOW)
print_bool("Overflow", pfx, check, CHECK_OVERFLOW);
+
+ if (err_type != ERR_TYPE_BUS)
+ return;
+
+ if (validation_bits & CHECK_VALID_BUS_PART_TYPE) {
+ u8 part_type = CHECK_BUS_PART_TYPE(check);
+
+ printk("%sParticipation Type: %u, %s\n", pfx, part_type,
+ part_type < ARRAY_SIZE(ia_check_bus_part_type_strs) ?
+ ia_check_bus_part_type_strs[part_type] : "unknown");
+ }
+
+ if (validation_bits & CHECK_VALID_BUS_TIME_OUT)
+ print_bool("Time Out", pfx, check, CHECK_BUS_TIME_OUT);
+
+ if (validation_bits & CHECK_VALID_BUS_ADDR_SPACE) {
+ u8 addr_space = CHECK_BUS_ADDR_SPACE(check);
+
+ printk("%sAddress Space: %u, %s\n", pfx, addr_space,
+ addr_space < ARRAY_SIZE(ia_check_bus_addr_space_strs) ?
+ ia_check_bus_addr_space_strs[addr_space] : "unknown");
+ }
}
void cper_print_proc_ia(const char *pfx, const struct cper_sec_proc_ia *proc)
--
2.14.1
next prev parent reply other threads:[~2018-02-23 20:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 20:03 [PATCH 0/8] Decode IA32/X64 CPER Yazen Ghannam
2018-02-23 20:03 ` [PATCH 1/8] efi: Fix IA32/X64 Processor Error Record definition Yazen Ghannam
2018-02-23 20:03 ` [PATCH 2/8] efi: Decode IA32/X64 Processor Error Section Yazen Ghannam
2018-02-24 16:38 ` Ard Biesheuvel
2018-02-26 15:55 ` Ghannam, Yazen
2018-02-23 20:03 ` [PATCH 3/8] efi: Decode IA32/X64 Processor Error Info Structure Yazen Ghannam
2018-02-24 16:40 ` Ard Biesheuvel
2018-02-26 16:00 ` Ghannam, Yazen
2018-02-26 16:04 ` Ard Biesheuvel
2018-02-23 20:03 ` [PATCH 4/8] efi: Decode UEFI-defined IA32/X64 Error Structure GUIDs Yazen Ghannam
2018-02-24 16:41 ` Ard Biesheuvel
2018-02-26 16:01 ` Ghannam, Yazen
2018-02-23 20:03 ` [PATCH 5/8] efi: Decode IA32/X64 Cache, TLB, and Bus Check structures Yazen Ghannam
2018-02-24 16:42 ` Ard Biesheuvel
2018-02-23 20:03 ` Yazen Ghannam [this message]
2018-02-24 16:43 ` [PATCH 6/8] efi: Decode additional IA32/X64 Bus Check fields Ard Biesheuvel
2018-02-23 20:03 ` [PATCH 7/8] efi: Decode IA32/X64 MS Check structure Yazen Ghannam
2018-02-24 16:43 ` Ard Biesheuvel
2018-02-23 20:03 ` [PATCH 8/8] efi: Decode IA32/X64 Context Info structure Yazen Ghannam
2018-02-24 16:45 ` Ard Biesheuvel
2018-02-26 16:05 ` Ghannam, Yazen
2018-02-26 16:06 ` Ard Biesheuvel
2018-02-24 16:46 ` [PATCH 0/8] Decode IA32/X64 CPER Ard Biesheuvel
2018-02-26 15:46 ` Ghannam, Yazen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223200333.6410-7-Yazen.Ghannam@amd.com \
--to=yazen.ghannam@amd.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bp@suse.de \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®