From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752491AbeBWVgE (ORCPT ); Fri, 23 Feb 2018 16:36:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:56572 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752228AbeBWVfy (ORCPT ); Fri, 23 Feb 2018 16:35:54 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D6AB217A9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Fri, 23 Feb 2018 15:35:52 -0600 From: Bjorn Helgaas To: Andy Shevchenko Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Jean Delvare , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper Message-ID: <20180223213552.GL14632@bhelgaas-glaptop.roam.corp.google.com> References: <20180222125923.57385-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180222125923.57385-1-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 22, 2018 at 02:59:20PM +0200, Andy Shevchenko wrote: > It's used in several places and more users may come. > By using this helper they may create a slightly cleaner code. > > Signed-off-by: Andy Shevchenko > --- > include/linux/dmi.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/linux/dmi.h b/include/linux/dmi.h > index 46e151172d95..241c27008c70 100644 > --- a/include/linux/dmi.h > +++ b/include/linux/dmi.h > @@ -147,4 +147,11 @@ static inline const struct dmi_system_id * > > #endif > > +static inline int dmi_get_bios_year(void) > +{ > + int year; > + dmi_get_date(DMI_BIOS_DATE, &year, NULL, NULL); > + return year; > +} I don't really care personally, and I assume this series will go via a non-PCI tree, but making this inline looks similar to this, which wasn't well-received: https://lkml.kernel.org/r/CA+55aFypU331cQy-6ZJ6szF=2KVLqcbwCUGd+gTwPViRqRWN+g@mail.gmail.com > #endif /* __DMI_H__ */ > -- > 2.16.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html