From: Jerry Hoemann <jerry.hoemann@hpe.com>
To: wim@linux-watchdog.org, linux@roeck-us.net
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
rwright@hpe.com, maurice.a.saldivar@hpe.com, mingo@kernel.org,
marcus.folkesson@gmail.com, Jerry Hoemann <jerry.hoemann@hpe.com>
Subject: [PATCH v4 06/10] watchdog/hpwdt: condition early return of NMI handler on iLO5
Date: Sun, 25 Feb 2018 14:32:55 -0700 [thread overview]
Message-ID: <20180225213259.2861-7-jerry.hoemann@hpe.com> (raw)
In-Reply-To: <20180225213259.2861-1-jerry.hoemann@hpe.com>
Modify prior change to not claim an NMI unless originated
from iLO to apply only to iLO5 and later going forward.
This restores hpwdt traditional behavior of calling panic
if the NMI is NMI_IO_CHECK, NMI_SERR, or NMI_UNKNOWN for
legacy hardware.
Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
---
drivers/watchdog/hpwdt.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index 1a18326bc99d..e60c689ebdb2 100644
--- a/drivers/watchdog/hpwdt.c
+++ b/drivers/watchdog/hpwdt.c
@@ -32,6 +32,7 @@
#define HPWDT_MAX_TIMER TICKS_TO_SECS(65535)
#define DEFAULT_MARGIN 30
+static bool iLO5;
static unsigned int soft_margin = DEFAULT_MARGIN; /* in seconds */
static unsigned int reload; /* the computed soft_margin */
static bool nowayout = WATCHDOG_NOWAYOUT;
@@ -121,7 +122,7 @@ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs)
"3. OA Forward Progress Log\n"
"4. iLO Event Log";
- if ((ulReason == NMI_UNKNOWN) && mynmi)
+ if (iLO5 && ulReason == NMI_UNKNOWN && mynmi)
return NMI_DONE;
if (allow_kdump)
@@ -279,6 +280,9 @@ static int hpwdt_init_one(struct pci_dev *dev,
", timer margin: %d seconds (nowayout=%d).\n",
HPWDT_VERSION, hpwdt_dev.timeout, nowayout);
+ if (dev->subsystem_vendor == PCI_VENDOR_ID_HP_3PAR)
+ iLO5 = 1;
+
return 0;
error_wd_register:
--
2.13.6
next prev parent reply other threads:[~2018-02-25 21:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-25 21:32 [PATCH v4 00/10] watchdog/hpwdt: Update driver to use watchdog core Jerry Hoemann
2018-02-25 21:32 ` [PATCH v4 01/10] watchdog/hpwdt: Update copyright Jerry Hoemann
2018-02-25 23:57 ` [v4,01/10] " Guenter Roeck
2018-02-25 21:32 ` [PATCH v4 02/10] watchdog/hpwdt: Remove legacy NMI sourcing Jerry Hoemann
2018-02-25 21:32 ` [PATCH v4 03/10] watchdog/hpwdt: Update nmi_panic message Jerry Hoemann
2018-02-25 21:32 ` [PATCH v4 04/10] watchdog/hpwdt: Update Module info Jerry Hoemann
2018-02-25 21:32 ` [PATCH v4 05/10] watchdog/hpwdt: Modify to use watchdog core Jerry Hoemann
2018-02-26 0:44 ` [v4,05/10] " Guenter Roeck
2018-02-25 21:32 ` Jerry Hoemann [this message]
2018-02-25 23:48 ` [PATCH v4 06/10] watchdog/hpwdt: condition early return of NMI handler on iLO5 Guenter Roeck
2018-02-26 0:41 ` [v4, " Guenter Roeck
2018-02-25 21:32 ` [PATCH v4 07/10] watchdog/hpwdt: remove allow_kdump module parameter Jerry Hoemann
2018-02-25 21:32 ` [PATCH v4 08/10] watchdog/hpwdt: Programable Pretimeout NMI Jerry Hoemann
2018-02-25 21:32 ` [PATCH v4 09/10] watchdog/hpwdt: Add dynamic debug Jerry Hoemann
2018-02-25 21:32 ` [PATCH v4 10/10] watchdog/hpwdt: Update driver version Jerry Hoemann
2018-02-26 0:50 ` [PATCH v4 00/10] watchdog/hpwdt: Update driver to use watchdog core Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180225213259.2861-7-jerry.hoemann@hpe.com \
--to=jerry.hoemann@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marcus.folkesson@gmail.com \
--cc=maurice.a.saldivar@hpe.com \
--cc=mingo@kernel.org \
--cc=rwright@hpe.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®