From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751950AbeBZSTt (ORCPT ); Mon, 26 Feb 2018 13:19:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:52144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751758AbeBZSTp (ORCPT ); Mon, 26 Feb 2018 13:19:45 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2B1A217B4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Mon, 26 Feb 2018 12:19:43 -0600 From: Bjorn Helgaas To: Andy Shevchenko Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Jean Delvare , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 4/4] pci: Re-use new dmi_get_bios_year() helper Message-ID: <20180226181943.GC25159@bhelgaas-glaptop.roam.corp.google.com> References: <20180222125923.57385-1-andriy.shevchenko@linux.intel.com> <20180222125923.57385-4-andriy.shevchenko@linux.intel.com> <20180223214051.GN14632@bhelgaas-glaptop.roam.corp.google.com> <1519565224.10722.148.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1519565224.10722.148.camel@linux.intel.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 25, 2018 at 03:27:04PM +0200, Andy Shevchenko wrote: > On Fri, 2018-02-23 at 15:40 -0600, Bjorn Helgaas wrote: > > On Thu, Feb 22, 2018 at 02:59:23PM +0200, Andy Shevchenko wrote: > > > ...instead of open coding its functionality. > > > > Same comment about making the changelog complete, independent of the > > subject. > > Any suggestion how it would look like? (Same question for previous > comment) PCI: Re-use new dmi_get_bios_year() helper Use new dmi_get_bios_year() helper instead of open-coding its functionality. The usual document structure is something like: TITLE This abstract contains a summary of the entire document, in a few paragraphs of complete sentences. Where "TITLE" makes sense all by itself, even without reading the body, and "Body" is a complete statement that also makes sense all by itself without having to read "TITLE" first. Granted, it's trivial, but following the convention improves readability slightly because it fits the reader's expectations. When the body is "...instead of open coding its functionality", it's a bit of a hiccup because I have to start over and look back up to the title to re-read the thing as a whole. Bjorn