From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752084AbeB0G72 (ORCPT ); Tue, 27 Feb 2018 01:59:28 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:33991 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751759AbeB0G71 (ORCPT ); Tue, 27 Feb 2018 01:59:27 -0500 X-Google-Smtp-Source: AH8x224rdhD21pgdU/tDCIlcAu0xBD4m7ZbnzX9wHtBO0LstJteo08jXJhG1sgr9vq4vlajCf96i8A== Date: Tue, 27 Feb 2018 07:59:22 +0100 From: Ingo Molnar To: Pavel Tatashin Cc: steven.sistare@oracle.com, daniel.m.jordan@oracle.com, jgross@suse.com, akataria@vmware.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, boris.ostrovsky@oracle.com, akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, luto@kernel.org, labbott@redhat.com, kirill.shutemov@linux.intel.com, bp@suse.de, minipli@googlemail.com, jinb.park7@gmail.com, dan.j.williams@intel.com, bhe@redhat.com, zhang.jia@linux.alibaba.com, mgorman@techsingularity.net, hannes@cmpxchg.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org Subject: Re: [v2 1/1] xen, mm: Allow deferred page initialization for xen pv domains Message-ID: <20180227065922.u6y7bcx3pwyags2u@gmail.com> References: <20180226160112.24724-1-pasha.tatashin@oracle.com> <20180226160112.24724-2-pasha.tatashin@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180226160112.24724-2-pasha.tatashin@oracle.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Pavel Tatashin wrote: > Juergen Gross noticed that commit > f7f99100d8d ("mm: stop zeroing memory during allocation in vmemmap") > broke XEN PV domains when deferred struct page initialization is enabled. > > This is because the xen's PagePinned() flag is getting erased from struct > pages when they are initialized later in boot. > > Juergen fixed this problem by disabling deferred pages on xen pv domains. > It is desirable, however, to have this feature available as it reduces boot > time. This fix re-enables the feature for pv-dmains, and fixes the problem > the following way: > > The fix is to delay setting PagePinned flag until struct pages for all > allocated memory are initialized, i.e. until after free_all_bootmem(). > > A new x86_init.hyper op init_after_bootmem() is called to let xen know > that boot allocator is done, and hence struct pages for all the allocated > memory are now initialized. If deferred page initialization is enabled, the > rest of struct pages are going to be initialized later in boot once > page_alloc_init_late() is called. > > xen_after_bootmem() walks page table's pages and marks them pinned. > > Signed-off-by: Pavel Tatashin > --- > arch/x86/include/asm/x86_init.h | 2 ++ > arch/x86/kernel/x86_init.c | 1 + > arch/x86/mm/init_32.c | 1 + > arch/x86/mm/init_64.c | 1 + > arch/x86/xen/mmu_pv.c | 38 ++++++++++++++++++++++++++------------ > mm/page_alloc.c | 4 ---- > 6 files changed, 31 insertions(+), 16 deletions(-) Acked-by: Ingo Molnar Thanks, Ingo