From: David Miller <davem@davemloft.net>
To: helgaas@kernel.org
Cc: dwmw2@infradead.org, sparclinux@vger.kernel.org,
bhelgaas@google.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] sparc: Use generic pci_mmap_resource_range()
Date: Wed, 28 Feb 2018 22:28:53 -0500 (EST) [thread overview]
Message-ID: <20180228.222853.1570972177848923005.davem@davemloft.net> (raw)
In-Reply-To: <20180228230828.GR127842@bhelgaas-glaptop.roam.corp.google.com>
From: Bjorn Helgaas <helgaas@kernel.org>
Date: Wed, 28 Feb 2018 17:08:29 -0600
> On Mon, Feb 19, 2018 at 10:30:25AM -0500, David Miller wrote:
>> From: David Woodhouse <dwmw2@infradead.org>
>> Date: Mon, 19 Feb 2018 15:24:18 +0000
>>
>> >> For one, the sparc specific code allows mmap'ing any address range
>> >> within a PCI bus device. The generic code does not allow that.
>> >
>> >
>> > You mean any address range in a given PCI bus even if there is no
>> > actual device with a BAR at the corresponding address?
>> >
>> > Would I be right to assume this was only available through the legacy
>> > procfs API? I think it should be possible to accommodate it, and it
>> > does look like I'd missed this requirement the first time round; thanks
>> > for pointing it out.
>>
>> It was probably the case that only procfs could do it.
>>
>> It is the mechanism by which we were able to let the X server poke
>> around in VGA ISA space. It does a bus I/O space map for the bus
>> device above the VGA card.
>
> What's the bottom line? Do we want this for sparc? If so, do you
> want to take it, Dave M, or would you like me to?
The bottom line is that David W.'s patch would break sparc so
we don't want this.
next prev parent reply other threads:[~2018-03-01 3:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 13:04 David Woodhouse
2018-02-19 14:49 ` David Miller
2018-02-19 15:24 ` David Woodhouse
2018-02-19 15:30 ` David Miller
2018-02-28 23:08 ` Bjorn Helgaas
2018-03-01 3:28 ` David Miller [this message]
2018-03-01 6:53 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228.222853.1570972177848923005.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhelgaas@google.com \
--cc=dwmw2@infradead.org \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®