From: Christoph Hellwig <hch@lst.de>
To: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: keith.busch@intel.com, axboe@fb.com, hch@lst.de,
sagi@grimberg.me, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] nvme-pci: assign separate irq vectors for adminq and ioq0
Date: Wed, 28 Feb 2018 17:47:26 +0100 [thread overview]
Message-ID: <20180228164726.GB16536@lst.de> (raw)
In-Reply-To: <1519832921-13915-1-git-send-email-jianchao.w.wang@oracle.com>
Note that we originally allocates irqs this way, and Keith changed
it a while ago for good reasons. So I'd really like to see good
reasons for moving away from this, and some heuristics to figure
out which way to use. E.g. if the device supports more irqs than
I/O queues your scheme might always be fine.
next prev parent reply other threads:[~2018-02-28 16:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 15:48 Jianchao Wang
2018-02-28 15:59 ` Andy Shevchenko
2018-03-02 3:06 ` jianchao.wang
2018-03-12 18:59 ` Keith Busch
2018-03-13 1:47 ` jianchao.wang
2018-02-28 16:47 ` Christoph Hellwig [this message]
2018-03-01 9:28 ` Sagi Grimberg
2018-03-01 10:05 ` jianchao.wang
2018-03-01 15:15 ` Keith Busch
2018-03-02 3:11 ` jianchao.wang
2018-03-01 15:03 ` Ming Lei
2018-03-01 16:10 ` Keith Busch
2018-03-08 7:42 ` Christoph Hellwig
2018-03-09 17:24 ` Keith Busch
2018-03-12 9:09 ` Ming Lei
2018-03-02 3:18 ` jianchao.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228164726.GB16536@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=jianchao.w.wang@oracle.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome