mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	x86@kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	jailhouse-dev@googlegroups.com, linux-pci@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2 4/6] x86: Consolidate PCI_MMCONFIG configs
Date: Wed, 28 Feb 2018 12:22:52 -0600	[thread overview]
Message-ID: <20180228182252.GG127842@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <CAHp75Vf35N1Q0aVjKNwz5UMAVKR-q8PypoDhgr8bCbbiqVeSqQ@mail.gmail.com>

On Wed, Feb 28, 2018 at 05:45:37PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 28, 2018 at 8:34 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> > From: Jan Kiszka <jan.kiszka@siemens.com>
> >
> > Not sure if those two worked by design or just by chance so far. In any
> > case, it's at least cleaner and clearer to express this in a single
> > config statement.

It would be nice if this were a complete statement of what the patch
does, but without the subject, it's not.  E.g., as I'm composing this
response in an editor window, I can't see the subject, so it seems
incomplete.

> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> >  arch/x86/Kconfig | 9 +++------
> >  1 file changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index eb7f43f23521..63e85e7da12e 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -2641,8 +2641,9 @@ config PCI_DIRECT
> >         depends on PCI && (X86_64 || (PCI_GODIRECT || PCI_GOANY || PCI_GOOLPC || PCI_GOMMCONFIG))
> >
> >  config PCI_MMCONFIG
> > -       def_bool y
> > -       depends on X86_32 && PCI && (ACPI || SFI) && (PCI_GOMMCONFIG || PCI_GOANY)
> > +       bool "Support mmconfig PCI config space access" if X86_64
> > +       default y
> > +       depends on PCI && (ACPI || SFI) && (PCI_GOMMCONFIG || PCI_GOANY || X86_64)
> 
> Looking to the above context I would rather put it like
> 
> depends on PCI && (ACPI || SFI) && (X86_64 || (PCI_GOANY || PCI_GOMMCONFIG))

The changelog doesn't point out any intended functional change, but I
think both these proposals add some new configs that previously could
not occur, e.g.,

  CONFIG_X86_64=y
  CONFIG_SFI=y
  # CONFIG_ACPI is unset
  CONFIG_PCI_MMCONFIG=y

If this is intended, the changelog should mention it.

  reply	other threads:[~2018-02-28 18:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28  6:34 [PATCH v2 0/6] jailhouse: Enhance secondary Jailhouse guest support /wrt PCI Jan Kiszka
2018-02-28  6:34 ` [PATCH v2 1/6] jailhouse: Provide detection for non-x86 systems Jan Kiszka
2018-02-28  6:34 ` [PATCH v2 2/6] PCI: Scan all functions when running over Jailhouse Jan Kiszka
2018-02-28  8:44   ` Thomas Gleixner
2018-02-28 10:01     ` Jan Kiszka
2018-02-28  6:34 ` [PATCH v2 3/6] x86/jailhouse: Enable PCI mmconfig access in inmates Jan Kiszka
2018-02-28  6:34 ` [PATCH v2 4/6] x86: Consolidate PCI_MMCONFIG configs Jan Kiszka
2018-02-28 15:45   ` Andy Shevchenko
2018-02-28 18:22     ` Bjorn Helgaas [this message]
2018-02-28  6:34 ` [PATCH v2 5/6] x86/jailhouse: Allow to use PCI_MMCONFIG without ACPI Jan Kiszka
2018-02-28  6:34 ` [PATCH v2 6/6] MAINTAINERS: Add entry for Jailhouse Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180228182252.GG127842@bhelgaas-glaptop.roam.corp.google.com \
    --to=helgaas@kernel.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=hpa@zytor.com \
    --cc=jailhouse-dev@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®