Re: [PATCH 05/11] kexec_file: Use read-only sections in arch_kexec_apply_relocations*

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2206 bytes --]

Hi Philipp,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v4.16-rc3 next-20180228]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Philipp-Rudo/kexec_file-Clean-up-purgatory-load/20180228-223538
config: i386-randconfig-a0-201808 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/linux/crash_dump.h:5:0,
                    from drivers/scsi/aacraid/commsup.c:36:
>> include/linux/kexec.h:296:10: warning: 'struct purgatory_info' declared inside parameter list
             const Elf_Shdr *symtab);
             ^
>> include/linux/kexec.h:296:10: warning: its scope is only this definition or declaration, which is probably not what you want
   include/linux/kexec.h:300:6: warning: 'struct purgatory_info' declared inside parameter list
         const Elf_Shdr *symtab);
         ^

vim +296 include/linux/kexec.h

   286	
   287	int __weak arch_kexec_kernel_image_probe(struct kimage *image, void *buf,
   288						 unsigned long buf_len);
   289	void * __weak arch_kexec_kernel_image_load(struct kimage *image);
   290	int __weak arch_kimage_file_post_load_cleanup(struct kimage *image);
   291	int __weak arch_kexec_kernel_verify_sig(struct kimage *image, void *buf,
   292						unsigned long buf_len);
   293	int __weak arch_kexec_apply_relocations_add(struct purgatory_info *pi,
   294						    Elf_Shdr *section,
   295						    const Elf_Shdr *relsec,
 > 296						    const Elf_Shdr *symtab);
   297	int __weak arch_kexec_apply_relocations(struct purgatory_info *pi,
   298						Elf_Shdr *section,
   299						const Elf_Shdr *relsec,
   300						const Elf_Shdr *symtab);
   301	void arch_kexec_protect_crashkres(void);
   302	void arch_kexec_unprotect_crashkres(void);
   303	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29777 bytes --]